public inbox for [email protected]  

help / color / mirror / Atom feed
From: Paul A Jungwirth <[email protected]>
To: jian he <[email protected]>
Cc: Kirill Reshke <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Subject: Re: DELETE/UPDATE FOR PORTION OF with rule system is not working
Date: Sun, 19 Apr 2026 11:07:47 -0700
Message-ID: <CA+renyVv5+_R=VViLfqN_E5HzwakDRiX=ZXH7AoDD3FB7+348w@mail.gmail.com> (raw)
In-Reply-To: <CACJufxFSTwzJxFYwD5mb5hSj9CvZxBh500Sza0CKoFCxB6iLsg@mail.gmail.com>
References: <CACJufxHs1Hs00EqsZ4NbuAjmYzMzjJyP1sAj12Ne=cBsEVmQOA@mail.gmail.com>
	<CALdSSPiRHCyC0fYy_E=gO+c7sbwU=7=Fz2CF-4aEa3mAe7yYAg@mail.gmail.com>
	<CACJufxGjgdWnhq5X5VL9orLXyKx-ZayT_Zj_-bAKr=kf0pZ_Nw@mail.gmail.com>
	<CA+renyXkcs=5P3dd=OoyM+A=UKA7iR_zS4TAQ42F9NTv+2RNiA@mail.gmail.com>
	<CACJufxFSTwzJxFYwD5mb5hSj9CvZxBh500Sza0CKoFCxB6iLsg@mail.gmail.com>

On Thu, Apr 16, 2026 at 8:20 PM jian he <[email protected]> wrote:
>
> On Thu, Apr 16, 2026 at 6:40 AM Paul A Jungwirth
> <[email protected]> wrote:
> >
> > I only have two small suggestions:
> >
> > Please use '[1, 11)' syntax to match the other tests.
> >
> > Breaking these long lines would be nice. For example:
> >
> > +CREATE RULE fpo_rule1 AS ON INSERT TO fpo_rule
> > +  DO INSTEAD UPDATE fpo_rule FOR PORTION OF f2 FROM 1 TO 4 SET f1 = 2;
> >
> Please check the attached v2.
>
> V1 only has DO INSTEAD rules, adding one DO ALSO rule would make the
> test coverage more robust.

Thanks for those changes. This looks great to me!

Yours,

-- 
Paul              ~{:-)
[email protected]





view thread (9+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: DELETE/UPDATE FOR PORTION OF with rule system is not working
  In-Reply-To: <CA+renyVv5+_R=VViLfqN_E5HzwakDRiX=ZXH7AoDD3FB7+348w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox