public inbox for [email protected]  

help / color / mirror / Atom feed

From: Greg Burd <[email protected]>
To: Robert Haas <[email protected]>
To: Michael Paquier <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: Tue, 16 Sep 2025 08:55:59 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmobduQcEntxF=SgsA3xZ-BPxL6BhgOSHY50SS34isPac1Q@mail.gmail.com>
References: <CA+TgmobduQcEntxF=SgsA3xZ-BPxL6BhgOSHY50SS34isPac1Q@mail.gmail.com>


On Sep 16 2025, at 8:02 am, Robert Haas <[email protected]> wrote:

> On Tue, Sep 16, 2025 at 2:04 AM Michael Paquier <[email protected]> wrote:
>> one SQL function mapping to each C function we are testing?
>  
> Yes, I think we should do this, if possible.

Michael, Robert,

Thanks for your time reviewing the proposed code and for providing
feedback. This patch started life as simply copy of the test_radixtree
module which uses a single test function triggered in SQL, hence my
approach.  I guess I should have copied the test_slru module instead! :)

I see the value in the idea of splitting it up into separate functions
and I'll give that a try.

Michael, apologies for the white space issues.  I'll clean that up, and
thank you for the `git diff --check` tip, I'll add that to my toolbox/routine.

> --  
> Robert Haas
> EDB: http://www.enterprisedb.com

best.

-greg

view thread (81+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Add tests for Bitmapset
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox