public inbox for [email protected]  

help / color / mirror / Atom feed

From: Thom Brown <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Baji Shaik <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Fix psql tab completion for REPACK boolean options
Date: Mon, 18 May 2026 12:04:18 +0100
Message-ID: <CAA-aLv79Gs3daW-=+invvemr5nxBzHm9Kn=DAC21qj8YWvQ1pw@mail.gmail.com> (raw)
In-Reply-To: <CAHGQGwGAY4kfDtC4i+hAOX-a3u0yOA6__6EDTQz-ytsDHgh-yQ@mail.gmail.com>
References: <CAHGQGwELJkyH+JH6j=rxgNhs_EA8+49kj65YbH85x-QG79qWyg@mail.gmail.com>
	<[email protected]>
	<CAHGQGwGAY4kfDtC4i+hAOX-a3u0yOA6__6EDTQz-ytsDHgh-yQ@mail.gmail.com>

On Fri, 15 May 2026 at 10:36, Fujii Masao <[email protected]> wrote:
>
> On Wed, May 13, 2026 at 9:46 PM Álvaro Herrera <[email protected]> wrote:
> > > Thanks for the patch! It looks good to me.
> > > Unless there are objections, I will commit it.
> >
> > Yeah, looks good to me, thanks.
>
> I've pushed the patch. Thanks!
>
> > Fine with me.  I wouldn't have a problem saying it's a backpatchable
> > bugfix, but it's certainly not very high priority or criticality.
>
> Agreed.
>
>
> BTW, while testing REPACK boolean options, I found two other issues
> in their parsing.
>
> First, REPACK (CONCURRENTLY OFF) failed with:
>
>     ERROR:  unrecognized REPACK option "concurrently"
>
> even though REPACK (CONCURRENTLY ON) works correctly. That is,
> CONCURRENTLY was treated as an unrecognized option when disabled.
>
> Second, when the same option is specified multiple times, the last value
> is not always honored. In particular, if any occurrence sets an option to ON,
> the option remains enabled even when the final setting is OFF.
>
> I think these are bugs, and the attached patch fixes them. Thoughts?

I saw this just got committed. Is there a reason the option handling
for this, VACUUM, and EXPLAIN aren't done in one place?

Thom

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix psql tab completion for REPACK boolean options
  In-Reply-To: <CAA-aLv79Gs3daW-=+invvemr5nxBzHm9Kn=DAC21qj8YWvQ1pw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox