public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: Masahiko Sawada <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
Date: Wed, 7 Sep 2022 09:16:54 +0530
Message-ID: <CAA4eK1+S7h2Tp6hWuEXyVNNrBNeO91pxJNSp3NmNL34FxHZbbQ@mail.gmail.com> (raw)
In-Reply-To: <CAD21AoDKLPA6tWqYCpBz3quKARmaMfQ_bM_oH6Erdsbou_O0aw@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CAA4eK1+=bifvdFw+36pV5Q1LGfdV5seUvVkd+JwaQ+U3G+dBqg@mail.gmail.com>
<CAD21AoDKLPA6tWqYCpBz3quKARmaMfQ_bM_oH6Erdsbou_O0aw@mail.gmail.com>
On Tue, Sep 6, 2022 at 7:40 PM Masahiko Sawada <[email protected]> wrote:
>
> > > I think they should say something like
> > >
> > > "logical replication starts skipping transaction with LSN %X/%X"
> > > "logical replication completed skipping transaction with LSN %X/%X"
> > >
> >
> > This looks better to me.
>
> +1
>
> > If you find the above argument to
> > differentiate between the start and end LSN convincing then we can
> > think of replacing "with" in the above messages with "finished at". I
> > see your point related to using "finished at" for PREPARE may not be a
> > good idea but I don't have better ideas for the same.
>
> Given that the user normally doesn't need to be aware of the
> difference between start LSN and end LSN in the context of using this
> feature, I think we can use "with LSN %X/%X".
>
Fair enough.
Alvaro, would you like to push your proposed change? Otherwise, I am
happy to take care of this.
--
With Regards,
Amit Kapila.
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
In-Reply-To: <CAA4eK1+S7h2Tp6hWuEXyVNNrBNeO91pxJNSp3NmNL34FxHZbbQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox