public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Gyan Sreejith <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: shveta malik <[email protected]>
Cc: Shlok Kyal <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
Date: Wed, 1 Apr 2026 10:26:53 +0530
Message-ID: <CAA4eK1+f3d=mkbCKrJPP8dH_Rs5COvKZZg5DaSh-1XS_Nzwv3Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <OSOPR01MB1215385EAC6A76650444E40B0F54FA@OSOPR01MB12153.jpnprd01.prod.outlook.com>
<TYRPR01MB12156F431E4B83ECFF14034BDF54CA@TYRPR01MB12156.jpnprd01.prod.outlook.com>
<CAEqnbaXb-TKUm7P-=_zrgQ=shRXkkZscPOHEL9OS6Cb2V8YT8Q@mail.gmail.com>
<CAA4eK1JiAzaY7UYnya7uDhX-kAL1PrsOAxBtys7c35t4q4H3_A@mail.gmail.com>
<CAEqnbaVF0yXQk=VVzr-8V23E=iUpUqyah6hxx2fy0ZVJh+CaGA@mail.gmail.com>
<CAJpy0uAwPNG3GN5+jTajnccLe+F1mW6dZh-9112u3QQQYugA=Q@mail.gmail.com>
<CAA4eK1JyYHPgaPTow5co8wBh8Ga+fx=vqHLhk2zHeqdOGYN4Vg@mail.gmail.com>
<OS9PR01MB12149FECFFF25973C167F9CFAF54BA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<CAEqnbaULSSQcir8Z8KDXduV4o4NZvJLeBMZN0VW3wh5QZjpEnw@mail.gmail.com>
<OS9PR01MB1214926DB01BF19C09368188EF548A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<CAHut+PsmdpYZnXKLYJ8n07-ftaPAbvxH9xuNrvm2c6zxS09z7Q@mail.gmail.com>
<CAEqnbaWsrDhsrBJucqiL7Bx9MKgB3F6imFAE7tF63MZ6okRmAg@mail.gmail.com>
<CAA4eK1JSg3HKm-cFDv0D5adSk8Kbsd6OG=B=HaOU-tLQt2NZ6Q@mail.gmail.com>
<[email protected]>
On Tue, Mar 31, 2026 at 5:36 PM Peter Eisentraut <[email protected]> wrote:
>
> On 25.03.26 09:25, Amit Kapila wrote:
> > On Wed, Mar 25, 2026 at 5:43 AM Gyan Sreejith <[email protected]> wrote:
> >>
> >> Thank you, Kuroda-san and Chao for the suggestions and the patch. I have merged it with v18-0001, and I have fixed everything that Peter suggested.
> >>
> >
> > Pushed after minor changes.
>
> Instead of creating a new logging API in pg_createsubscriber locally,
> why not extend logging.c to support a log file.
>
Few things we may want to consider if we want to use extended
logging.c: (a) what if we want information to be written in multiple
files (say pub/sub specific info into separate files), something like
what pg_upgrade does, (b) what if we want to write some info to only
one of terminal or log_file, we can probably extend generic API for
this.
> This is much simpler,
> doesn't require caller changes, and could be reused elsewhere. See
> attached patches. (The 0003 and 0004 are just some additional code
> simplifications.)
>
In 0004,
-static char logdir[MAXPGPATH]; /* Subdirectory of the user specified logdir
+static char *logdir = NULL; /* Subdirectory of the user specified logdir
At other places like pg_upgrade, we use MAXPGPATH for a similar case
probably to have standard length on all platforms, see
make_outputdirs() in pg_upgrade.c.
--
With Regards,
Amit Kapila.
view thread (55+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
In-Reply-To: <CAA4eK1+f3d=mkbCKrJPP8dH_Rs5COvKZZg5DaSh-1XS_Nzwv3Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox