public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Kapila <[email protected]>
To: shveta malik <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Robert Haas <[email protected]>
Subject: Re: Regardign RecentFlushPtr in WalSndWaitForWal()
Date: Mon, 11 Mar 2024 16:36:18 +0530
Message-ID: <CAA4eK1J+k_7Z1+D108zaTZKiSszAnjdAMhogs6a7cKEsGFsjjQ@mail.gmail.com> (raw)
In-Reply-To: <CAJpy0uAx_dw6m1-yCtumgZ7jD3t4EP3V0QnDwhg4G3h6yAi8hA@mail.gmail.com>
References: <CAJpy0uBSCQz1yMD-WiEthzEe23dti2-Kr_pitVb7vAPFbFKm=A@mail.gmail.com>
	<CAEze2Wgm=TvEeDmmyR3pF70k1vhbQFC25fUrV3cRk2HdEECxvg@mail.gmail.com>
	<CAA4eK1+LO+x6RREH434TGw4E_TK1UnrDK8nTL0xLQb4uFEdVMg@mail.gmail.com>
	<CAJpy0uAx_dw6m1-yCtumgZ7jD3t4EP3V0QnDwhg4G3h6yAi8hA@mail.gmail.com>

On Mon, Mar 11, 2024 at 4:17 PM shveta malik <[email protected]> wrote:
>
> On Sat, Mar 2, 2024 at 4:44 PM Amit Kapila <[email protected]> wrote:
> >
> > Right, I think the quoted code has check "if (!RecoveryInProgress())".
> >
> > >
> >  But apart from that, your
> > > observation seems accurate, yes.
> > >
> >
> > I also find the observation correct and the code has been like that
> > since commit 5a991ef8 [1]. So, let's wait to see if Robert or Andres
> > remembers the reason, otherwise, we should probably nuke this code.
>
> Please find the patch attached for the same.
>

LGTM. I'll push this tomorrow unless I see any comments/objections to
this change.

-- 
With Regards,
Amit Kapila.

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Regardign RecentFlushPtr in WalSndWaitForWal()
  In-Reply-To: <CAA4eK1J+k_7Z1+D108zaTZKiSszAnjdAMhogs6a7cKEsGFsjjQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox