public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: shveta malik <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: Doruk Yilmaz <[email protected]>
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
Date: Mon, 16 Feb 2026 14:22:57 +0530
Message-ID: <CAA4eK1JgkWgg3hfxSPsOgtamh4sgWLFQqYFL_oEhqHgtHhJriA@mail.gmail.com> (raw)
In-Reply-To: <CAA4eK1KV2orcjQmdNmBO4EQQ7GXxEJ2kRy_d+1mOH-CEqtTYbg@mail.gmail.com>
References: <CAJpy0uB19aKEgVgh8gwzj87NUyDgOf01boa-6xJZK+nhb=3W4g@mail.gmail.com>
<CAA4eK1+h4mOvRqRaGfUtSgZuBhzWWmrBcY3jQ4DDV=cEJ4dwnQ@mail.gmail.com>
<TY7PR01MB145543A74547443E49E4993E7F58EA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
<CAJpy0uD6D294d=Hq4oROmtKAew5DfKERNxs=DsAwUFBFF2kERg@mail.gmail.com>
<TY7PR01MB14554FB7D02601425DE3752DEF58FA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
<CAA4eK1JvYROk5usAX0Uy=00VACB=w1rvUcyoKvRuke5EMfmi3Q@mail.gmail.com>
<[email protected]>
<CAA4eK1KV2orcjQmdNmBO4EQQ7GXxEJ2kRy_d+1mOH-CEqtTYbg@mail.gmail.com>
On Wed, Feb 11, 2026 at 10:53 AM Amit Kapila <[email protected]> wrote:
>
> On Wed, Feb 4, 2026 at 12:38 AM Heikki Linnakangas <[email protected]> wrote:
> >
> > The new error message is not great:
> >
> > postgres=# select pg_replication_origin_session_setup('myorigin', 12345678);
> > ERROR: could not find replication state slot for replication origin
> > with OID 1 which was acquired by 12345678
> >
> > Firstly, replication origin is not an OID. Secondly, it's a little
> > confusing because the "replication state slot" is in fact present.
> > However, it's currently inactive, i.e. not "acquired" by the given PID.
> >
> > I propose to change that to:
> >
> > postgres=# select pg_replication_origin_session_setup('myorigin', 12345678);
> > ERROR: replication origin with ID 1 is not active for PID 12345678
> >
> > That's more in line with this neighboring message:
> >
> > ERROR: replication origin with ID 1 is already active for PID 701228
> >
>
> +1 for the new message.
>
Heikki, would you like to take care of improvements proposed by you?
Otherwise, I am happy to take care of them.
--
With Regards,
Amit Kapila.
view thread (43+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
In-Reply-To: <CAA4eK1JgkWgg3hfxSPsOgtamh4sgWLFQqYFL_oEhqHgtHhJriA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox