public inbox for [email protected]
help / color / mirror / Atom feedFrom: Sami Imseih <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: Robert Treat <[email protected]>
Cc: [email protected]
Cc: pgsql-hackers <[email protected]>
Subject: Re: Add pg_stat_autovacuum_priority
Date: Sat, 4 Apr 2026 08:25:26 -0500
Message-ID: <CAA5RZ0t6bCR6Pasd_eWqXvyUmrNDWmHUy1yN_Po-c4+b9BtBqQ@mail.gmail.com> (raw)
In-Reply-To: <adB6FQeoUst6gHA0@nathan>
References: <CALj2ACVnQRS=T8SY2zegfft=Nku1n6w5609JPdd9jqiM+G_gGg@mail.gmail.com>
<acwTxpz3Toxt0ty8@nathan>
<CAA5RZ0uVZLsX_k33QoWt8iRes73jyqs+EjypL9+1wW1v8NsYbg@mail.gmail.com>
<ac00otrpVnWzZ_i4@nathan>
<CAA5RZ0vFtDKAOZALeLp3vLyhWcLntaqS-Oh36Xxgx5_8sYeSKQ@mail.gmail.com>
<CAA5RZ0tOJjUuJidUQYAeoUD4VGjOSjuB7ox4dtLAsyoCZqSN+Q@mail.gmail.com>
<ac2ODZSOjWNzueHZ@nathan>
<CAA5RZ0uVg0L3vVvkOiHaY9ZJ+K9ZcsyQH0TVQ5rXSd-ZEeVFNg@mail.gmail.com>
<ac_vLKVgs4RYK1P-@nathan>
<CAA5RZ0sCRjH3xkHFdSXnKysdMZXFyaS_094+K-O_rr4Fkmwc=Q@mail.gmail.com>
<adB6FQeoUst6gHA0@nathan>
> WDYT?
"Scores greater than or equal to <literal>1.0</literal>" in the comments
of each field are misleading. This conflates scoring with vacuum/analyze
eligibility and it's possible with a autovacuum_*_weight < 1.0 to trigger an
autovacuum/analyze.
I suggest the attached changes on top of v9.
--
Sami
Attachments:
[application/octet-stream] 0001-sami_doc_fix.patch (3.9K, 2-0001-sami_doc_fix.patch)
download | inline diff:
From 0fe7be2e0c4d970d0ec21af007d600c5bb94d904 Mon Sep 17 00:00:00 2001
From: Sami Imseih <[email protected]>
Date: Sat, 4 Apr 2026 13:08:04 +0000
Subject: [PATCH 1/1] sami_doc_fix
---
doc/src/sgml/monitoring.sgml | 28 +++++++++-------------------
1 file changed, 9 insertions(+), 19 deletions(-)
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 34e3051c400..47ed7768345 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -4522,7 +4522,9 @@ description | Waiting for a newly initialized WAL file to reach durable storage
<para>
The <structname>pg_stat_autovacuum_scores</structname> view will contain one
row for each table in the current database (including TOAST tables), showing
- the current autovacuum scores for that specific table. See
+ the current autovacuum scores for that specific table. Tables eligible for
+ autovacuum are prioritized for processing based on their score, with higher
+ scores indicating higher priority. See
<xref linkend="autovacuum-priority"/> for more information.
</para>
@@ -4574,11 +4576,7 @@ description | Waiting for a newly initialized WAL file to reach durable storage
</para>
<para>
Maximum value of all component scores. This is the value that
- autovacuum uses to sort the list of tables to process. Scores greater
- than or equal to <literal>1.0</literal> indicate the table will be
- processed (unless autovacuum is disabled and neither
- <literal>xid_score</literal> nor <literal>mxid_score</literal> are
- greater than or equal to <literal>1.0</literal>).
+ autovacuum uses to sort the list of tables to process.
</para></entry>
</row>
@@ -4587,8 +4585,7 @@ description | Waiting for a newly initialized WAL file to reach durable storage
<structfield>xid_score</structfield> <type>double precision</type>
</para>
<para>
- Transaction ID age component score. Scores greater than or equal to
- <literal>1.0</literal> indicate the table will be vacuumed.
+ Transaction ID age component score.
</para></entry>
</row>
@@ -4597,8 +4594,7 @@ description | Waiting for a newly initialized WAL file to reach durable storage
<structfield>mxid_score</structfield> <type>double precision</type>
</para>
<para>
- Multixact ID age component score. Scores greater than or equal to
- <literal>1.0</literal> indicate the table will be vacuumed.
+ Multixact ID age component score.
</para></entry>
</row>
@@ -4607,9 +4603,7 @@ description | Waiting for a newly initialized WAL file to reach durable storage
<structfield>vacuum_score</structfield> <type>double precision</type>
</para>
<para>
- Vacuum component score. Scores greater than or equal to
- <literal>1.0</literal> indicate the table will be vacuumed (unless
- autovacuum is disabled).
+ Vacuum component score.
</para></entry>
</row>
@@ -4618,9 +4612,7 @@ description | Waiting for a newly initialized WAL file to reach durable storage
<structfield>vacuum_insert_score</structfield> <type>double precision</type>
</para>
<para>
- Vacuum insert component score. Scores greater than or equal to
- <literal>1.0</literal> indicate the table will be vacuumed (unless
- autovacuum is disabled).
+ Vacuum insert component score.
</para></entry>
</row>
@@ -4629,9 +4621,7 @@ description | Waiting for a newly initialized WAL file to reach durable storage
<structfield>analyze_score</structfield> <type>double precision</type>
</para>
<para>
- Analyze component score. Scores greater than or equal to
- <literal>1.0</literal> indicate the table will be analyzed (unless
- autovacuum is disabled).
+ Analyze component score.
</para></entry>
</row>
</tbody>
--
2.50.1
view thread (60+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add pg_stat_autovacuum_priority
In-Reply-To: <CAA5RZ0t6bCR6Pasd_eWqXvyUmrNDWmHUy1yN_Po-c4+b9BtBqQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox