public inbox for [email protected]
help / color / mirror / Atom feedFrom: Sami Imseih <[email protected]>
To: Corey Huinker <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: [email protected]
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
Date: Thu, 12 Mar 2026 16:08:34 -0500
Message-ID: <CAA5RZ0tiL01rYm7=WaDGLUYjvz+fQRqmaXyRUv9jKRnR3_6xDQ@mail.gmail.com> (raw)
In-Reply-To: <CADkLM=d-yUR8JsM-UmCfeRAhVj+X9MYi0kz9=zQO4EoBkd8H8A@mail.gmail.com>
References: <CADkLM=cz=bEvRRj0mSffMrVW56M=1O-KqavCZv19on-MQrkZwg@mail.gmail.com>
<aateiqvWO53UjoNI@nathan>
<aathGcXAIpiUSP_s@nathan>
<CAA5RZ0vCuDDd6-H00aabjLri0yO_AMJQ4Lb4017pepqU5WNyFg@mail.gmail.com>
<aa7sZcuRrlkeVJGX@nathan>
<CADkLM=eUR5co+o3PU8M=Fo8rRynj4xf=PFtt2KisD96bdrPEOg@mail.gmail.com>
<CAA5RZ0s674FM8vcEqr+DUVjWOpYSPS-rG8uANdJKEnSyo+tObA@mail.gmail.com>
<CADkLM=cYLk7bi3QVMBGWsFEzNfpqyV1Es3tWCwfERS88MdULWQ@mail.gmail.com>
<aa81xZp421DSkHiW@nathan>
<CADkLM=dhYeJtP+8h8k4ULCu-P1pNHmFyDFBm8B0WU6A6i+NgPQ@mail.gmail.com>
<abBIu0lYyFYAq5fx@nathan>
<CADkLM=d-=_hbOUsMc4u_ScLmSNox6EbzFCmaMn7MTh6f_SLU_A@mail.gmail.com>
<CADkLM=d-yUR8JsM-UmCfeRAhVj+X9MYi0kz9=zQO4EoBkd8H8A@mail.gmail.com>
> Apologies for the delay. I thought I had posted this. I rebased it against a630ac5c2016e52 (current HEAD).
Thanks!
just a few things.
v5-0001:
+-- Set up convenience views
+--
+CREATE VIEW stats_import.pg_stats_check AS
It will be good to add more commentary here to the next person adding
a test, and mention
that only stable values should be included in this view. what do you think?
v5-0002:
This is the wrong link. It should be catalog-pg-attribute and not
catalog-pg-class
+ (references <link
linkend="catalog-pg-class"><structname>pg_attribute</structname></link>.<structfield>attrelid</structfield>)
and a few occurrences where the link to pg_statistic_ext is pointing
to catalog-pg-class:
+ (references <link
linkend="catalog-pg-class"><structname>pg_statistic_ext</structname></link>.<structfield>stxrelid</structfield>)
v5-0003:
LGTM
--
Sami Imseih
Amazon Web Services (AWS)
view thread (36+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
In-Reply-To: <CAA5RZ0tiL01rYm7=WaDGLUYjvz+fQRqmaXyRUv9jKRnR3_6xDQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox