public inbox for [email protected]
help / color / mirror / Atom feedFrom: Corey Huinker <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Sami Imseih <[email protected]>
Cc: [email protected]
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
Date: Tue, 10 Mar 2026 12:42:02 -0400
Message-ID: <CADkLM=d-=_hbOUsMc4u_ScLmSNox6EbzFCmaMn7MTh6f_SLU_A@mail.gmail.com> (raw)
In-Reply-To: <abBIu0lYyFYAq5fx@nathan>
References: <CADkLM=cz=bEvRRj0mSffMrVW56M=1O-KqavCZv19on-MQrkZwg@mail.gmail.com>
<aateiqvWO53UjoNI@nathan>
<aathGcXAIpiUSP_s@nathan>
<CAA5RZ0vCuDDd6-H00aabjLri0yO_AMJQ4Lb4017pepqU5WNyFg@mail.gmail.com>
<aa7sZcuRrlkeVJGX@nathan>
<CADkLM=eUR5co+o3PU8M=Fo8rRynj4xf=PFtt2KisD96bdrPEOg@mail.gmail.com>
<CAA5RZ0s674FM8vcEqr+DUVjWOpYSPS-rG8uANdJKEnSyo+tObA@mail.gmail.com>
<CADkLM=cYLk7bi3QVMBGWsFEzNfpqyV1Es3tWCwfERS88MdULWQ@mail.gmail.com>
<aa81xZp421DSkHiW@nathan>
<CADkLM=dhYeJtP+8h8k4ULCu-P1pNHmFyDFBm8B0WU6A6i+NgPQ@mail.gmail.com>
<abBIu0lYyFYAq5fx@nathan>
On Tue, Mar 10, 2026 at 12:37 PM Nathan Bossart <[email protected]>
wrote:
> On Mon, Mar 09, 2026 at 06:42:46PM -0400, Corey Huinker wrote:
> > If you want 0003 split into two (one for pg_stats_ext and one for
> > pg_stats_ext_exprs) I can do that, but they felt like a package deal to
> me.
>
> Sorry to throw a curveball here, but I think the best way to structure this
> patch set is as follows:
>
> * 0001: Just the test changes (e.g., replacing * with column lists). By
> doing that first, the actual functionality changes in 0002 will be easier
> to see.
>
Makes sense.
>
> * 0002: Adding columns to the all the views (this one will do a catalog
> bump). If we need to make a couple of test adjustments to verify the OIDs
> or attribute IDs, that's fine, but those can be pretty minimal.
>
So all three views in one go. +1
>
> * 0003: Associated pg_dump changes.
>
On it.
view thread (36+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
In-Reply-To: <CADkLM=d-=_hbOUsMc4u_ScLmSNox6EbzFCmaMn7MTh6f_SLU_A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox