public inbox for [email protected]  

help / color / mirror / Atom feed

From: Henson Choi <[email protected]>
To: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Tue, 5 May 2026 18:15:29 +0900
Message-ID: <CAAAe_zAhXuBTRiNVU1RrJKOiKoyeu-pgYaYb8HaqbhSsC=sGUg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CACJufxEWL_ZnC-bs_yrg-Ys6ZUD3Ut_p1Ebj0bAcbzj67+HDAQ@mail.gmail.com>
	<[email protected]>

Hi Tatsuo, Jian,

Both coding-style items from Jian's review will be addressed and
included in the next patch series.

> 1. We need to add trailing commas to enum definitions. See
> >
> https://git.postgresql.org/cgit/postgresql.git/commit/?id=611806cd726fc92989ac918eac48fd8d684869c7
>
> I forgot that. Thanks for reminding.
>

Three enum types introduced by the patch lack a trailing comma on the
last enumerator: RPRNavKind, RPRNavOffsetKind, and RPRPatternNodeType.
All three will be corrected in the next series.


> > + (errcode(ERRCODE_SYNTAX_ERROR),
> > The leading parenthesis is optional and can be removed, fewer
> > parentheses are always better.
> > See related discussion:
> > https://postgr.es/m/[email protected]
>
> Right. I will review all other patches.


The outer-parentheses pattern appears in 17 ereport() calls in
parse_rpr.c and 2 in optimizer/plan/rpr.c.  All 19 sites will be
cleaned up in the next series.

Jian, I will review your other patches as well.

Best,
Henson

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <CAAAe_zAhXuBTRiNVU1RrJKOiKoyeu-pgYaYb8HaqbhSsC=sGUg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox