public inbox for [email protected]  

help / color / mirror / Atom feed

From: Henson Choi <[email protected]>
To: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Tue, 2 Jun 2026 23:11:05 +0900
Message-ID: <CAAAe_zAv0FZQfdjAX05QpE5qtdQQUrqEfZgOZRb1P9Qincircg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAAAe_zAuHwqUfqJOD4PDUkWsxTfTytNaandq11Kddw2bfCcpvQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hi Tatsuo,

Catching up on today's notes -- all straightforward, so I'm folding them
into one reply.

> I'd prefer (3). Yes, I agree that 240 pattern variables is enough.

Then (3) it is -- and with Jian on the same choice, that closes it. I'll
go ahead with it. Since it's a narrowing it's only free pre-release, so
it goes in the v48 core rather than a later follow-up.

> static void
> nfa_reevaluate_dependent_vars(WindowAggState *winstate, RPRNFAContext
*ctx,
>                               int64 currentPos)
>
> This function does not have a forward declaration. Moreover, it is put
> in the "API exposed to nodeWindowAgg.c" section. [...] I suggest to add
> a forward declaration for it and move it before "API exposed to
> nodeWindowAgg.c" section.

Agreed -- that was just an oversight. I'll add the forward declaration
and move it out of the API-exposed section.

> nocfbot-0025-...:55:+   (errcode(ERRCODE_WINDOWING_ERROR),
> Maybe this is the only one worth to look into?

Right -- I'll update 0025 in the next posting.

Thanks,
Henson

view thread (109+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <CAAAe_zAv0FZQfdjAX05QpE5qtdQQUrqEfZgOZRb1P9Qincircg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox