public inbox for [email protected]
help / color / mirror / Atom feedFrom: Henson Choi <[email protected]>
To: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Thu, 12 Mar 2026 09:39:57 +0900
Message-ID: <CAAAe_zDAQWje=SK65hstqEwMgbQGRH4P1=5yOmvgT7m2Mz8Qbw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CAN4CZFOEpz6vXitAkcCGixzAzp4uRRahyScWixKQZU=K4tngtQ@mail.gmail.com>
<CAAAe_zAFv0E_EhFxZueJ1n9pZpPaTVChMhDmndzugzovgz0o2Q@mail.gmail.com>
<[email protected]>
2026년 3월 12일 (목) AM 9:21, Tatsuo Ishii <[email protected]>님이 작성:
> Hi Zsolt,
>
> Thanks for the report and the test case!
>
> > Good catch, Zsolt. You're right ― the return value of
> > coerce_to_boolean() must be assigned back to te->expr, otherwise
> > any implicit cast (e.g., a user-defined type with an assignment
> > cast to boolean) is silently discarded.
> >
> > The fix is straightforward:
> >
> > foreach_ptr(TargetEntry, te, defineClause)
> > te->expr = (Expr *) coerce_to_boolean(pstate, (Node *) te->expr,
> > "DEFINE");
> >
> > I've confirmed that your example query produces incorrect results
> > without the fix (the truthyint value is evaluated as-is without
> > the cast) and correct results with it.
> >
> > Patch 13 is attached with the fix and a regression test case based
> > on your example.
>
> Yeah, current patch needs to be fixed. Question is, the output of the
> expression of DEFINE clause must be a strict boolean or, it is allowed
> to accept an expression coercive to boolean?
>
> If we prefer the former, we should use exprType() instead.
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
>
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Row pattern recognition
In-Reply-To: <CAAAe_zDAQWje=SK65hstqEwMgbQGRH4P1=5yOmvgT7m2Mz8Qbw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox