public inbox for [email protected]  

help / color / mirror / Atom feed
From: Henson Choi <[email protected]>
To: Aditya Gollamudi <[email protected]>
To: cca5507 <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Minor refactor of the code in ExecScanExtended()
Date: Wed, 25 Mar 2026 10:53:55 +0900
Message-ID: <CAAAe_zDyq-Yg-xL8FSNaeneSXmesFs6JefxNJo2coQQjP3RLcQ@mail.gmail.com> (raw)
In-Reply-To: <CAD-KL_G5Z_NbEkJcZhZu+ccWn39R9Sg9Zi3FZoKN_fRdNWDGnA@mail.gmail.com>
References: <[email protected]>
	<CAD-KL_G5Z_NbEkJcZhZu+ccWn39R9Sg9Zi3FZoKN_fRdNWDGnA@mail.gmail.com>

Hi hackers,

2026년 1월 19일 (월) PM 1:51, Aditya Gollamudi <[email protected]>님이 작성:

> On Sun, Jan 18, 2026 at 7:31 PM cca5507 <[email protected]> wrote:
>
>> Hi,
>>
>> The current code:
>>
>> if (!qual && !projInfo)
>> {
>> ResetExprContext(econtext);
>> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
>> }
>>
>> ResetExprContext(econtext);
>>
>> The following format might be simpler:
>>
>> ResetExprContext(econtext);
>>
>> if (!qual && !projInfo)
>> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
>>
>> Attach a patch to do this.
>>
>> --
>> Regards,
>> ChangAo Chen
>>
>> Hi,
>
> +1, seems like a simple refactor.
> Tests are passing locally for me!
>
> - Adi Gollamudi
>

+1, agreed.

The refactored version is cleaner and easier to read by moving
ResetExprContext() before the early return,
eliminating the duplicated logic.

Best regards,
Henson


view thread (4+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Minor refactor of the code in ExecScanExtended()
  In-Reply-To: <CAAAe_zDyq-Yg-xL8FSNaeneSXmesFs6JefxNJo2coQQjP3RLcQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox