public inbox for [email protected]
help / color / mirror / Atom feedFrom: Melanie Plageman <[email protected]>
To: Andres Freund <[email protected]>
Cc: [email protected]
Cc: Heikki Linnakangas <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Subject: Re: Unlogged rel fake lsn vs GetVictimBuffer()
Date: Tue, 10 Mar 2026 15:46:00 -0400
Message-ID: <CAAKRu_Ypx4+a3ycAJm276E0F3UiQfo-XeusOmjOzOajHCLNHZA@mail.gmail.com> (raw)
In-Reply-To: <CAAKRu_bwpjonq5ag2EBm2xDRRyfU8PpCFioG1o=8Ed9VKkRBfQ@mail.gmail.com>
References: <fmkqmyeyy7bdpvcgkheb6yaqewemkik3ls6aaveyi5ibmvtxnd@nu2kvy5rq3a6>
<CAAKRu_a0w7wVZCysJ1s6tEPkdsGyYR4iBSEUefa3Y2nWLx2vSw@mail.gmail.com>
<tsoi4ahsvxl7ln3ltmkhi4wn6p5b36uiokll5j2mzsfhpl6i7w@brc33vsxcdum>
<CAAKRu_b8+MYK1JsppdtUNV-f3UgEg3F7YihiSWvxoHeWgEN7BA@mail.gmail.com>
<CAAKRu_bwpjonq5ag2EBm2xDRRyfU8PpCFioG1o=8Ed9VKkRBfQ@mail.gmail.com>
On Tue, Mar 10, 2026 at 3:31 PM Melanie Plageman
<[email protected]> wrote:
>
> None of my points above are blockers, so barring any objections I plan
> to push this later today/tomorrow. It hasn't been sitting out long but
> it is pretty trivial and I don't think it has any correctness issues.
Now, I'm thinking that I should allow BufferNeedsWALFlush() to be
called on local buffers. I removed it in v2 because Andres mentioned
it could never happen when called by StrategyRejectBuffer() (because
we don't use strategies on local buffers), but there's no reason
BufferNeedsWALFlush() can't be used more widely in the future.
- Melanie
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Unlogged rel fake lsn vs GetVictimBuffer()
In-Reply-To: <CAAKRu_Ypx4+a3ycAJm276E0F3UiQfo-XeusOmjOzOajHCLNHZA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox