public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Rowley <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: [email protected]
Subject: Re: Use stack allocated StringInfoDatas, where possible (round 2)
Date: Mon, 13 Apr 2026 10:45:37 +1200
Message-ID: <CAApHDvp1d_tN-7ZVESZB9Eih+dGxxsWATC63nKLAjtM5yu_jxQ@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvqFBWx+Ghdy3_LXq5u+v-HCS0zwh4Pp+qtaSfJxmMhkiA@mail.gmail.com>
References: <[email protected]>
	<CAApHDvqFBWx+Ghdy3_LXq5u+v-HCS0zwh4Pp+qtaSfJxmMhkiA@mail.gmail.com>

On Mon, 13 Apr 2026 at 01:34, David Rowley <[email protected]> wrote:
> I think the author of copy_sequences() doesn't know what
> resetStringInfo() does. I expect they think that it'll pfree all the
> memory, but that's what destroyStringInfo() is for.

That was poor analysis. The resetStringInfo is there to reset the
StringInfo before the next loop. So nothing is wrong with it.

I've now pushed your patch.

David

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Use stack allocated StringInfoDatas, where possible (round 2)
  In-Reply-To: <CAApHDvp1d_tN-7ZVESZB9Eih+dGxxsWATC63nKLAjtM5yu_jxQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox