public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Rowley <[email protected]>
To: David Geier <[email protected]>
Cc: [email protected]
Subject: Re: Hashed IN only applied to first encountered IN
Date: Wed, 2 Apr 2025 12:00:01 +1300
Message-ID: <CAApHDvqSFcGvyYVJZAk7BW544cd4KY3B9KofnjkCdpV49hwVGg@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvpmfXrcWvxpfJ7GtX=rD7L9H8Z5e6r=xXWESbR=HTJCsQ@mail.gmail.com>
References: <[email protected]>
	<CAApHDvpmfXrcWvxpfJ7GtX=rD7L9H8Z5e6r=xXWESbR=HTJCsQ@mail.gmail.com>

On Wed, 2 Apr 2025 at 01:31, David Rowley <[email protected]> wrote:
>
> On Wed, 2 Apr 2025 at 00:51, David Geier <[email protected]> wrote:
> > The hashed IN optimization is only applied to the first encountered
> > ScalarArrayOpExpr during the expression tree traversal in
> > convert_saop_to_hashed_saop_walker(). Reason being that the walker
> > returns true which aborts the traversal.
>
> > I've also attached a patch with a fix.
>
> Thanks for the report and fix.  On first inspection your patch looks
> fine.  I'll have a closer look tomorrow.

I've now pushed and backpatched the relevant portion of this back to v14.

Thanks again.

David

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Hashed IN only applied to first encountered IN
  In-Reply-To: <CAApHDvqSFcGvyYVJZAk7BW544cd4KY3B9KofnjkCdpV49hwVGg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox