public inbox for [email protected]
help / color / mirror / Atom feedFrom: Xuneng Zhou <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Nazir Bilal Yavuz <[email protected]>
Subject: Re: Streamify more code paths
Date: Mon, 16 Mar 2026 11:05:42 +0800
Message-ID: <CABPTF7VsyyLOehrgj3E2G4yYFwS=sRZofXCtX9R-cAPojfLz2A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CABPTF7X3RBkmOnQAoLbK-tr6o-+27fNpKPgzYZHhQCuYbP=rGA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CABPTF7Wz8OCcr2f1CSdt-jRHfJAAdXZwwBokBD4baZAPyK7CgA@mail.gmail.com>
<CABPTF7UA3sEw1ZpAj8qAKY6Xs71sk41X-pV43_iZHZz2U_AP=Q@mail.gmail.com>
<[email protected]>
<CABPTF7XxdAA681duGKgWx-eLC1skR3giuebcw4+-0GkOVZm-pw@mail.gmail.com>
<[email protected]>
<CABPTF7U4CvFp55wVg51b8b24J1GQfjB62SzvfXY0ZgjaRWPYfA@mail.gmail.com>
<CABPTF7WONbvOOJPKwpPmh0Pu6scFZbCwxKq5ThdPiWEfdMjfjA@mail.gmail.com>
<[email protected]>
On Mon, Mar 16, 2026 at 9:00 AM Michael Paquier <[email protected]> wrote:
>
> On Sun, Mar 15, 2026 at 11:47:06AM +0800, Xuneng Zhou wrote:
> > The updated script now reports speedup separately for the read and
> > write paths like this:
> >
> > hash_vacuum_medium base= 33747.2ms patch= 27379.7ms 1.23x ( 18.9%)
> > read: 4662→1612 ops 8238.72→1725.86ms
> > (4.77x) write: 12689→12651 ops 25146.51→25053.57ms (1.00x)
> >
> > I think it is useful to keep the write-delay option even with this
> > reporting. Separating the read and write delays also helps reduce the
> > overall runtime of the tests, especially for large data sizes: we only
> > slow down the read path while keeping the write path fast.
>
> These write numbers are more in line with what I was seeing in my last
> tests, and I am not going to ignore a 20% runtime reduction. The
> stats numbers are looking nice, as well.
>
> At the end, I have checked the logic of what you are introducing,
> where things come down to the point of making sure that the data
> pushed to the callback remains consistent with the paths where
> _hash_getcachedmetap() is called. I have also cross-checked the data
> reports by pgstattuple for the relation and the index, to see that
> these are consistent between HEAD and the patch, just in case. And
> applied it. That was the last piece.
> --
> Michael
Thanks for double-checking and pushing it.
--
Best,
Xuneng
view thread (36+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Streamify more code paths
In-Reply-To: <CABPTF7VsyyLOehrgj3E2G4yYFwS=sRZofXCtX9R-cAPojfLz2A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox