public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nisha Moond <[email protected]>
To: Lakshmi N <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION
Date: Mon, 27 Apr 2026 13:58:58 +0530
Message-ID: <CABdArM4nF-QTeOsGt40NAngeeH7yJ4RVtMU4hWjVM4=fNYPrdw@mail.gmail.com> (raw)
In-Reply-To: <CA+3i_M98-XjE-_fw0p+8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg@mail.gmail.com>
References: <CA+3i_M98-XjE-_fw0p+8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg@mail.gmail.com>

On Mon, Apr 27, 2026 at 11:03 AM Lakshmi N <[email protected]> wrote:
>
> Hi hackers,
>
> In CreateSubscription(), the subretentionactive catalog column (declared as
> bool in pg_subscription.h) is populated using Int32GetDatum() instead of
> BoolGetDatum():
>
> This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with the
> ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().
>
> The attached patch fixes this to use BoolGetDatum(), matching both the
> catalog definition and the ALTER path.
>

+1
This looks like an oversight in commit a850be2.

--
Thanks,
Nisha

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION
  In-Reply-To: <CABdArM4nF-QTeOsGt40NAngeeH7yJ4RVtMU4hWjVM4=fNYPrdw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox