public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nisha Moond <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix column privileges for pg_subscription.subwalrcvtimeout
Date: Thu, 4 Jun 2026 11:09:27 +0530
Message-ID: <CABdArM5tnrvRogzmjh+duuXPgMFGKYVdYJkdEEiqT22wsFcD2g@mail.gmail.com> (raw)
In-Reply-To: <CAHGQGwFyY_JDkM3twz-dS8wQgzd7_n6oayQk27Oqz1f7LTWEzw@mail.gmail.com>
References: <CABdArM4uA=6nA0BunJwudiEoY1BcWUS_oj_2pkEq_d-YdiBJhw@mail.gmail.com>
	<CAHGQGwEOvk0ioxT+eGX-6vHO=2kQRXwKcbOku0qW2cEZ0DnJiQ@mail.gmail.com>
	<CAA4eK1KbUpkEq5Pv0_ORLqxea-Gzi=PJjvVS4T-r+WTuKDGQMA@mail.gmail.com>
	<CAHGQGwFyY_JDkM3twz-dS8wQgzd7_n6oayQk27Oqz1f7LTWEzw@mail.gmail.com>

On Thu, Jun 4, 2026 at 7:35 AM Fujii Masao <[email protected]> wrote:
>
> On Tue, Jun 2, 2026 at 11:56 AM Amit Kapila <[email protected]> wrote:
> > > BTW, should we add a regression test for column privileges on pg_subscription
> > > to help catch similar issues in the future?
> > >
> >
> > +1. It makes sense because I noticed that patch authors previously
> > also omitted this part though in most cases those are caught in
> > review.
>
> Agreed. I've added the regression test to the patch.
> Attached is the updated version.
>

Thank you, Fujii-san, for the updated patch. I tested both the success
and failure cases with the SQL query, and it worked as expected.

The patch LGTM.

--
Thanks,
Nisha

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fix column privileges for pg_subscription.subwalrcvtimeout
  In-Reply-To: <CABdArM5tnrvRogzmjh+duuXPgMFGKYVdYJkdEEiqT22wsFcD2g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox