public inbox for [email protected]  
help / color / mirror / Atom feed
From: jian he <[email protected]>
To: Quan Zongliang <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: PostgreSQL Development <[email protected]>
Subject: Re: [PATCH] Remove dead code in ExecForPortionOfLeftovers()
Date: Wed, 22 Apr 2026 12:24:08 +0800
Message-ID: <CACJufxE7cpK_eY+HXVFD_DBfMpRxCUoHfZBKRYLwgKW2NB8=Rw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAJ7c6TN9ETkTxdcwuexovXrXdpNWcxzQ7iiTes+_xpEWC5xO0Q@mail.gmail.com>
	<[email protected]>

On Wed, Apr 22, 2026 at 11:58 AM Quan Zongliang <[email protected]> wrote:
>
>
> On 4/21/26 8:22 PM, Aleksander Alekseev wrote:
> > Hi,
> >
> > While reading 8e72d914c528 I noticed that
> > ForPortionOfState.fp_leftoverstypcache is not used for anything. I
> > suggest removing it, as attached.
> >
>
> Agree.
> It indeed did not make any reference anywhere.
>

I raised this issue at [1].
But apparently, it's actually being used for fixing a bug at [2].

[1]: https://www.postgresql.org/message-id/CACJufxHYntqy2fo9CFWDDrqKjcMK8DGRM3kse4YnXYnPYq2Hiw%40mail.gma...
[2]: https://www.postgresql.org/message-id/CA%2BrenyU5%3Dmihx6O8%2BERBmarZcuV1QiWB3X5bZhdptWoRM9G-Aw%40ma...





view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Remove dead code in ExecForPortionOfLeftovers()
  In-Reply-To: <CACJufxE7cpK_eY+HXVFD_DBfMpRxCUoHfZBKRYLwgKW2NB8=Rw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox