public inbox for [email protected]
help / color / mirror / Atom feedFrom: jian he <[email protected]>
To: Mahendra Singh Thalor <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Srinath Reddy <[email protected]>
Cc: [email protected]
Subject: Re: Non-text mode for pg_dumpall
Date: Thu, 20 Feb 2025 17:18:13 +0800
Message-ID: <CACJufxFMa=gtKYSrPu_jnCYYT700SexbPONOGFjodZKc7A3Nyg@mail.gmail.com> (raw)
In-Reply-To: <CAKYtNAppgqMUjuyn7a8s-guvZuwyqt=nm99CkJ1gaME7K4eEKQ@mail.gmail.com>
References: <CAKYtNAoyQV-UKosfFDfm_ZqdC-oYaRT-01jMv1k+o9OSyXovTg@mail.gmail.com>
<[email protected]>
<CAKYtNAppgqMUjuyn7a8s-guvZuwyqt=nm99CkJ1gaME7K4eEKQ@mail.gmail.com>
hi.
about 0001
/*
* connectDatabase
*
* Make a database connection with the given parameters. An
* interactive password prompt is automatically issued if required.
*
* If fail_on_error is false, we return NULL without printing any message
* on failure, but preserve any prompted password for the next try.
*
* On success, the global variable 'connstr' is set to a connection string
* containing the options used.
*/
PGconn *
connectDatabase(const char *dbname, const char *connection_string,
const char *pghost, const char *pgport, const char *pguser,
trivalue prompt_password, bool fail_on_error, const
char *progname,
const char **connstr, int *server_version)
do the comments need to change? since no
global variable 'connstr' in common_dumpall_restore.c
maybe we need some words to explain server_version, (i don't have a
huge opinion though).
/*-------------------------------------------------------------------------
*
* common_dumpall_restore.c
*
* Portions Copyright (c) 1996-2025, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* This is a common file for pg_dumpall and pg_restore.
* src/bin/pg_dump/common_dumpall_restore.c
*
*-------------------------------------------------------------------------
*/
may change to
/*-------------------------------------------------------------------------
*
* common_dumpall_restore.c
* This is a common file for pg_dumpall and pg_restore.
*
* Portions Copyright (c) 1996-2025, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* IDENTIFICATION
* src/bin/pg_dump/common_dumpall_restore.c
*
*-------------------------------------------------------------------------
*/
so the style aligns with most other files.
(we can apply the same logic to src/bin/pg_dump/common_dumpall_restore.h)
in src/bin/pg_dump/pg_dumpall.c
#include "common_dumpall_restore.h"
imply include "pg_backup.h".
so in src/bin/pg_dump/pg_dumpall.c, we don't need include "pg_backup.h"
attached are minor cosmetic changes for v19.
Attachments:
[application/octet-stream] v19_minor_change.no-cfbot (3.6K, 2-v19_minor_change.no-cfbot)
download
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Non-text mode for pg_dumpall
In-Reply-To: <CACJufxFMa=gtKYSrPu_jnCYYT700SexbPONOGFjodZKc7A3Nyg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox