public inbox for [email protected]  

help / color / mirror / Atom feed

From: jian he <[email protected]>
To: PostgreSQL-development <[email protected]>
Subject: ATExecColumnDefault comments
Date: Thu, 5 Sep 2024 21:50:26 +0800
Message-ID: <CACJufxFmLZTzmOV83O2Dd0Buh=HNYtPUs6VAcUGLv+KCWSyqqg@mail.gmail.com> (raw)

hi.
one minor issue for ATExecColumnDefault comments.


/*
 * ALTER TABLE ALTER COLUMN SET/DROP DEFAULT
 *
 * Return the address of the affected column.
 */
static ObjectAddress
ATExecColumnDefault(Relation rel, const char *colName,
                    Node *newDefault, LOCKMODE lockmode)

the comment should be:
 * ALTER TABLE ALTER COLUMN SET/DROP DEFAULT
 * ALTER VIEW  ALTER COLUMN SET/DROP DEFAULT
?


Sometimes, comments are useful for quickly glance at what this function does.
Therefore I guess reword it would be helpful.

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: ATExecColumnDefault comments
  In-Reply-To: <CACJufxFmLZTzmOV83O2Dd0Buh=HNYtPUs6VAcUGLv+KCWSyqqg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox