public inbox for [email protected]
help / color / mirror / Atom feedFrom: jian he <[email protected]>
To: Robert Treat <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Antonin Houska <[email protected]>
Cc: Mihail Nikalayeu <[email protected]>
Subject: Re: Adding REPACK [concurrently]
Date: Wed, 5 Nov 2025 16:46:04 +0800
Message-ID: <CACJufxGp7HOxw_6V+xEUg=5=XUpxdH33LUdXuLjEyQHEWfjOzQ@mail.gmail.com> (raw)
In-Reply-To: <CAJSLCQ0UhdwrF-FBHN6DuPNmTb8mqq-=_jdxjscqoMXjnBkJbw@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CACJufxFPiasoUXFR4SK2QRq6mnztiX=3F82=8PyBrdocX5awBw@mail.gmail.com>
<CAJSLCQ0UhdwrF-FBHN6DuPNmTb8mqq-=_jdxjscqoMXjnBkJbw@mail.gmail.com>
On Wed, Nov 5, 2025 at 1:11 PM Robert Treat <[email protected]> wrote:
> > --------------------
> >
> > + printf(_(" --index[=INDEX] repack following an index\n"));
> > should it be
> > + printf(_("--index[=INDEX] repack following an index\n"));
> > ?
> >
>
> I believe this is included for alignment, since this option has no
> shorthand version.
>
if you compare pg_dump --help, pg_repackdb --help
then you will see the inconsistency.
This is legacy behavior, but can we move some of the error checks in
do_analyze_rel to an earlier point?
we call cluster_rel before analyze_rel, cluster_rel is way more time-consuming,
a failure in analyze_rel means all the previous work (cluster_rel) is wasted.
+ else if (HeadMatches("REPACK", "(*") &&
+ !HeadMatches("REPACK", "(*)"))
+ {
+ /*
+ * This fires if we're in an unfinished parenthesized option list.
+ * get_previous_words treats a completed parenthesized option list as
+ * one word, so the above test is correct.
+ */
+ if (ends_with(prev_wd, '(') || ends_with(prev_wd, ','))
+ COMPLETE_WITH("VERBOSE");
+ else if (TailMatches("VERBOSE"))
+ COMPLETE_WITH("ON", "OFF");
+ }
this part can also support the ANALYZE option?
ClusterStmt
should be removed from src/tools/pgindent/typedefs.list?
doc/src/sgml/ref/clusterdb.sgml
<para>
<application>clusterdb</application> has been superceded by
<application>pg_repackdb</application>.
</para>
google told me, "superceded" should be "superseded"
--
jian he
EDB: http://www.enterprisedb.com
view thread (106+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <CACJufxGp7HOxw_6V+xEUg=5=XUpxdH33LUdXuLjEyQHEWfjOzQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox