public inbox for [email protected]  

help / color / mirror / Atom feed

From: Önder Kalacı <[email protected]>
To: [email protected] <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Date: Mon, 20 Mar 2023 12:28:06 +0300
Message-ID: <CACawEhVMOdx61mDg9OJRuJa-ST04=XUX6tF_rS59b-XywtFeHw@mail.gmail.com> (raw)
In-Reply-To: <OSZPR01MB6310B8C55B6184B07958B0A9FD809@OSZPR01MB6310.jpnprd01.prod.outlook.com>
References: <CACawEhVQC9WoofunvXg12aXtbqKnEgWxoRx3+v8q32AWYsdpGg@mail.gmail.com>
	<OSZPR01MB6310CE109F65A9B62A25CE1EFDB99@OSZPR01MB6310.jpnprd01.prod.outlook.com>
	<CACawEhUCg-tRGzRqRq+qHaR+kPdZ=N1fP=A4_cCYd0LuNLUgnA@mail.gmail.com>
	<CAA4eK1+ZXLQLCKOwEzvpCJ2XXapANY66S773zMbqbUL_7LBUiQ@mail.gmail.com>
	<OSZPR01MB6310A7627F4587CB5547086AFDBC9@OSZPR01MB6310.jpnprd01.prod.outlook.com>
	<CACawEhVCoCj5n1LUWBd12gd1S9ONkB3jf7fw5kK5njA==1X3rg@mail.gmail.com>
	<CAA4eK1LLsHLnq9F62brVV3EfA7oqStJoQ6ki89Jy1UHBMRrYVA@mail.gmail.com>
	<CACawEhWkFwQ5Zuu9NOQiJtjnQY+At8JuhKQ6cJ7wEvWv+Vb=+g@mail.gmail.com>
	<OSZPR01MB63107F0FFFF821A14747277DFDBD9@OSZPR01MB6310.jpnprd01.prod.outlook.com>
	<CACawEhUAW2Jiwo3xwYSoB0rfjuWMtYhS_X+ZVHWXZBysjKPXKg@mail.gmail.com>
	<OSZPR01MB6310B8C55B6184B07958B0A9FD809@OSZPR01MB6310.jpnprd01.prod.outlook.com>

Hi Shi Yu, all

Thanks for updating the patches. It seems you forgot to attach the patches
> of
> dropped columns for HEAD and pg15, I think they are the same as v2.
>
>
Yes, it seems I forgot. And, yes they were the same as v2.


> On HEAD, we can re-use clusters in other test cases, which can save some
> time.
> (see fccaf259f22f4a)
>
>
 Thanks for noting.


> In the patches for pg12 and pg11, I am not sure why not add the test at
> end of
> the file 100_bugs.pl. I think it would be better to be consistent with
> other
> versions.
>

I applied the same patch that I created for HEAD, and then the "patch"
command
created this version. Given that we are creating new patches per version, I
think
you are right, we should put them at the end.



> The attached patches modify these two points. Besides, I made some minor
> changes, ran pgindent and pgperltidy.


oh, I didn't know about pgperltidy. And, thanks a lot for making changes and
making it ready for the committer.


> These are patches for dropped columns,
> because I think this would be submitted first, and we can discuss the fix
> for
> generated columns later.
>
>
Makes sense, even now we have 5 different patches, lets work on generated
columns
when this is fixed.

I applied all patches for all the versions, and re-run the subscription
tests,
all looks good to me.


Thanks,
Onder KALACI

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
  In-Reply-To: <CACawEhVMOdx61mDg9OJRuJa-ST04=XUX6tF_rS59b-XywtFeHw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox