public inbox for [email protected]help / color / mirror / Atom feed
[PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry 3+ messages / 2 participants [nested] [flat]
* [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry @ 2026-04-18 03:29 Tatsuya Kawata <[email protected]> 2026-04-20 20:31 ` Re: [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry Masahiko Sawada <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Tatsuya Kawata @ 2026-04-18 03:29 UTC (permalink / raw) To: pgsql-hackers Hi, The second function signature of pg_get_tablespace_ddl() in the "Get Object DDL Functions" table is missing the func_signature role attribute on its <para> tag. This causes inconsistent indentation compared to the first signature in the rendered documentation. Other functions with multiple signatures, such as current_schema, use <para role="func_signature"> for each signature entry. The attached patch fixes this by adding the missing role attribute. Regards, Tatsuya Kawata Attachments: [application/octet-stream] 0001-Doc-Fix-missing-func_signature-role-in-pg_get_tables.patch (1.2K, 3-0001-Doc-Fix-missing-func_signature-role-in-pg_get_tables.patch) download | inline diff: From 59f75092ed5c6406202645bc5f467703f1c9fa56 Mon Sep 17 00:00:00 2001 From: TatsuyaKawata <[email protected]> Date: Sat, 18 Apr 2026 12:09:46 +0900 Subject: [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry The second function signature for pg_get_tablespace_ddl() was missing the func_signature role attribute on its <para> tag, causing inconsistent indentation in the rendered documentation. Author: Tatsuya Kawata <[email protected]> --- doc/src/sgml/func/func-info.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/func/func-info.sgml b/doc/src/sgml/func/func-info.sgml index 80cf11083d6..00f64f50ceb 100644 --- a/doc/src/sgml/func/func-info.sgml +++ b/doc/src/sgml/func/func-info.sgml @@ -3921,7 +3921,7 @@ acl | {postgres=arwdDxtm/postgres,foo=r/postgres} <type>text</type> </optional> ) <returnvalue>setof text</returnvalue> </para> - <para> + <para role="func_signature"> <function>pg_get_tablespace_ddl</function> ( <parameter>tablespace</parameter> <type>name</type> <optional>, <literal>VARIADIC</literal> <parameter>options</parameter> -- 2.34.1 ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry 2026-04-18 03:29 [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry Tatsuya Kawata <[email protected]> @ 2026-04-20 20:31 ` Masahiko Sawada <[email protected]> 2026-04-21 14:56 ` Re: [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry Tatsuya Kawata <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Masahiko Sawada @ 2026-04-20 20:31 UTC (permalink / raw) To: Tatsuya Kawata <[email protected]>; +Cc: pgsql-hackers On Fri, Apr 17, 2026 at 8:30 PM Tatsuya Kawata <[email protected]> wrote: > > Hi, > > The second function signature of pg_get_tablespace_ddl() > in the "Get Object DDL Functions" table is missing > the func_signature role attribute on its <para> tag. > This causes inconsistent indentation compared to > the first signature in the rendered documentation. > > Other functions with multiple signatures, such as current_schema, > use <para role="func_signature"> for each signature entry. > The attached patch fixes this by adding the missing role attribute. LGTM. Pushed. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry 2026-04-18 03:29 [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry Tatsuya Kawata <[email protected]> 2026-04-20 20:31 ` Re: [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry Masahiko Sawada <[email protected]> @ 2026-04-21 14:56 ` Tatsuya Kawata <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Tatsuya Kawata @ 2026-04-21 14:56 UTC (permalink / raw) To: Masahiko Sawada <[email protected]>; +Cc: pgsql-hackers Hi Sawada-san, Thank you for the quick review and for pushing the patch. I really appreciate it. Regards, Tatsuya Kawata ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-04-21 14:56 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-18 03:29 [PATCH] Doc: Fix missing func_signature role in pg_get_tablespace_ddl entry Tatsuya Kawata <[email protected]> 2026-04-20 20:31 ` Masahiko Sawada <[email protected]> 2026-04-21 14:56 ` Tatsuya Kawata <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox