public inbox for [email protected]
help / color / mirror / Atom feedFrom: Mihail Nikalayeu <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Antonin Houska <[email protected]>
Cc: Robert Treat <[email protected]>
Cc: Fujii Masao <[email protected]>
Subject: Re: Adding REPACK [concurrently]
Date: Fri, 26 Sep 2025 16:27:12 +0200
Message-ID: <CADzfLwXUcQL-dK7J7KKxTnPR95ruc5wHP71rKYG35fnt4MktpA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
Hello!
Álvaro Herrera <[email protected]>:
> So here's v22 with those and rebased to current sources. Only the first
> two patches this time, which are the ones I would be glad to receive
> input on.
> get_tables_to_repack_partitioned(RepackCommand cmd, MemoryContext cluster_context,
> Oid relid, bool rel_is_index)
Should we rename it to repack_context to be aligned with the calling side?
---------
'cmd' in
> static List *get_tables_to_repack(RepackCommand cmd, bool usingindex,
> MemoryContext permcxt);
but 'command' in
> get_tables_to_repack(RepackCommand command, bool usingindex,
> MemoryContext permcxt)
---------
> cmd == REPACK_COMMAND_CLUSTER ? "CLUSTER" : "REPACK",
May be changed to RepackCommandAsString
-----------
if (cmd == REPACK_COMMAND_REPACK)
pgstat_progress_update_param(PROGRESS_REPACK_COMMAND,
PROGRESS_REPACK_COMMAND_REPACK);
else if (cmd == REPACK_COMMAND_CLUSTER)
{
pgstat_progress_update_param(PROGRESS_REPACK_COMMAND,
PROGRESS_CLUSTER_COMMAND_CLUSTER);
} else ....
'{' and '}' looks a little bit weird.
--------
Documentation of pg_repackdb contains a lot of "analyze" and even
"--analyze" parameter - but I can't see anything related in the code.
Best regards,
Mikhail.
view thread (106+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <CADzfLwXUcQL-dK7J7KKxTnPR95ruc5wHP71rKYG35fnt4MktpA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox