public inbox for [email protected]  

help / color / mirror / Atom feed

From: Guillaume Lelarge <[email protected]>
To: Ilia Evdokimov <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Ibrar Ahmed <[email protected]>
Cc: Gregory Stark (as CFM) <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: vignesh C <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: [email protected]
Subject: Re: explain analyze rows=%.0f
Date: Sat, 11 Jan 2025 10:15:06 +0100
Message-ID: <CAECtzeVpocPwcQ0ccrXsmcvH_8YkJBdUfsJCzb8NKrEodmCg_w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CA+TgmoZv8DvmeQHQAX+rkn68id2N+DoUhFZB36d-_w1tyAeqeA@mail.gmail.com>
	<[email protected]>
	<CAA4eK1Lmo0FX6Nfr_k3-UX1Hpei1H-xPHL6Wwx7SLUP3s+O1mA@mail.gmail.com>
	<CA+Tgmob0BBeK6GEMUQBPiv0kJpTJSEgX+OUD2FeY42zWVgJuLw@mail.gmail.com>
	<[email protected]>
	<CALtqXTfM3GJbFsB63ajfHcYvFhUA0ySX4f4MVS3Dau2vopU+Rw@mail.gmail.com>
	<CAM-w4HNLRO8QJvF3x13wjjdkJHobORxaKrcuyF1cKaTiXuvDbA@mail.gmail.com>
	<CALtqXTcZE6YW=m9ZmNU6sRJ+RTC15NFc__foP1S2KaWvGOf6JA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hello,

Le jeu. 12 déc. 2024 à 12:57, Ilia Evdokimov <[email protected]>
a écrit :

>
> On 01.08.2023 23:29, Daniel Gustafsson wrote:
> >> On 3 Jul 2023, at 18:34, Daniel Gustafsson <[email protected]> wrote:
> >>
> >>> On 8 Jun 2023, at 19:49, Ibrar Ahmed <[email protected]> wrote:
> >>> On Mon, Mar 20, 2023 at 7:56 PM Gregory Stark (as CFM) <
> [email protected] <mailto:[email protected]>> wrote:
> >>> This patch was marked Returned with Feedback and then later Waiting on
> >>> Author. And it hasn't had any updates since January. What is the state
> >>> on this feedback? If it's already done we can set the patch to Ready
> >>> for Commit and if not do you disagree with the proposed changes?
> >>>
> >>> If there is a consensus to modify the test cases' output, I am willing
> to
> >>> make the necessary changes and adjust the patch accordingly. However,
> >>> if there is a preference to keep the output of certain test cases
> unchanged,
> >>> I can rebase and modify the patch accordingly to accommodate those
> preferences.
> >> As there hasn't been any other comments I suggest updating your patch to
> >> address Tom's comments to see if we can make progress here.
> > Since there hasn't been any updates here, and the thread has been
> stalled, I'm
> > marking this returned with feedback.  Please feel free to resubmit a
> version of
> > the patch addressing comments to a future CF.
> >
> > --
> > Daniel Gustafsson
> >
> >
> >
>
> Hi everybody,
>
> When the total number of returned tuples is less than the number of
> loops currently shows 'rows = 0'. This can mislead users into thinking
> that no rows were returned at all, even though some might have appeared
> occasionally. For example, if there is 1 tuple over 100 loops, the
> average is 0.01 rows per loop, but as displayed it simply looks like zero.
>
> To clarify this situation, it has been suggested that display rows with
> two decimal places in scenarios where 'loops > 1 && ntuples < loops'. In
> other words, show something like 'rows = 0.01' instead of 'rows=0'. This
> minor change would make it evident that rows did occur, just very
> infrequently.
>
> For all other cases, the current formatting would remain the same. This
> approach aims to provide a more nuanced understanding of query execution
> behavior without introducing unnecessary complexity or false precision.
>
> I would appreciate any thoughts or feedback on this proposal.
>
>
Thanks for your patch, this looks like a very interesting feature that I'd
like to see in a future release.

It did a quick run: patch OK, make OK, make install OK, but make check
fails quite a lot on partition_prune.sql.

I guess it would need some work on partition_prune.sql tests and perhaps
also on the docs.

Thanks again.


-- 
Guillaume.

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: explain analyze rows=%.0f
  In-Reply-To: <CAECtzeVpocPwcQ0ccrXsmcvH_8YkJBdUfsJCzb8NKrEodmCg_w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox