public inbox for [email protected]  
help / color / mirror / Atom feed
From: Ilia Evdokimov <[email protected]>
To: Guillaume Lelarge <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Ibrar Ahmed <[email protected]>
Cc: Gregory Stark (as CFM) <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: vignesh C <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: [email protected]
Subject: Re: explain analyze rows=%.0f
Date: Sat, 11 Jan 2025 21:21:16 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAECtzeUz=8HSUnNMF+mbLywH+JVZ9uJv-b-=O1dTT4KZAFPyhQ@mail.gmail.com>
References: <CA+TgmoZv8DvmeQHQAX+rkn68id2N+DoUhFZB36d-_w1tyAeqeA@mail.gmail.com>
	<[email protected]>
	<CAA4eK1Lmo0FX6Nfr_k3-UX1Hpei1H-xPHL6Wwx7SLUP3s+O1mA@mail.gmail.com>
	<CA+Tgmob0BBeK6GEMUQBPiv0kJpTJSEgX+OUD2FeY42zWVgJuLw@mail.gmail.com>
	<[email protected]>
	<CALtqXTfM3GJbFsB63ajfHcYvFhUA0ySX4f4MVS3Dau2vopU+Rw@mail.gmail.com>
	<CAM-w4HNLRO8QJvF3x13wjjdkJHobORxaKrcuyF1cKaTiXuvDbA@mail.gmail.com>
	<CALtqXTcZE6YW=m9ZmNU6sRJ+RTC15NFc__foP1S2KaWvGOf6JA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAECtzeVpocPwcQ0ccrXsmcvH_8YkJBdUfsJCzb8NKrEodmCg_w@mail.gmail.com>
	<[email protected]>
	<CAECtzeUz=8HSUnNMF+mbLywH+JVZ9uJv-b-=O1dTT4KZAFPyhQ@mail.gmail.com>


On 11.01.2025 17:02, Guillaume Lelarge wrote:
> Le sam. 11 janv. 2025 à 12:10, Ilia Evdokimov 
> <[email protected]> a écrit :
>
>
>     On 11.01.2025 12:15, Guillaume Lelarge wrote:
>>
>>
>>     Thanks for your patch, this looks like a very interesting feature
>>     that I'd like to see in a future release.
>>
>>     It did a quick run: patch OK, make OK, make install OK, but make
>>     check fails quite a lot on partition_prune.sql.
>>
>>     I guess it would need some work on partition_prune.sql tests and
>>     perhaps also on the docs.
>>
>>     Thanks again.
>>
>>
>>     -- 
>>     Guillaume.
>
>
>     Yes, certainly. I have fixed partition_prune.sql. In the
>     documentation example for EXPLAIN ANALYZE where loops is greater
>     than one, I updated how 'rows' and 'loops' values are displayed so
>     they appear as decimal fractions with two digits after the decimal
>     point.
>
>     I attached fixed patch.
>
>     Any suggestions?
>
>
> Thanks for the updated patch.
>
> "make check" is happy, so no more suggestions, except you should 
> register it in the next commitfest.
>
>
> -- 
> Guillaume.


Done!

https://commitfest.postgresql.org/52/5501/

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.


view thread (9+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: explain analyze rows=%.0f
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox