public inbox for [email protected]  

help / color / mirror / Atom feed

From: Junwang Zhao <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Andrey Borodin <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Subject: Re: Official devcontainer config
Date: Sun, 4 Aug 2024 10:07:40 +0800
Message-ID: <CAEG8a3+av_p4fLA=dAAp1U7nMckt+D=qjEOVxqOio39u48qEkQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAEG8a3K_mZsBZ60smh4FM4Dk9cazAUmM72iXdFKEHgthZnaHcw@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On Sat, Aug 3, 2024 at 2:45 AM Peter Eisentraut <[email protected]> wrote:
>
> On 01.08.24 23:38, Andrew Dunstan wrote:
> > Not totally opposed, and I will probably give it a try very soon, but
> > I'm wondering if this really needs to go in the core repo. We've
> > generally shied away from doing much in the way of editor / devenv
> > support, trying to be fairly agnostic. It's true we carry .dir-locals.el
> > and .editorconfig, so that's not entirely true, but those are really
> > just about supporting our indentation etc. standards.
>
> Yeah, the editor support in the tree ought to be minimal and factual,
> based on coding standards and widely recognized best practices, not a
> collection of one person's favorite aliases and scripts.  If the scripts
> are good, let's look at them and maybe put them under src/tools/ for
> everyone to use.  But a lot of this looks like it will requite active
> maintenance if output formats or node formats or build targets etc.
> change.  And other things require specific local paths.  That's fine for
> a local script or something, but not for a mainline tool that the
> community will need to maintain.

Yeah, personal favorite aliases and scripts are not good, that
also concerns me, I will delete those parts in future patches.

>
> I suggest to start with a very minimal configuration. What are the
> settings that absolute everyone will need, maybe to set indentation
> style or something.
>

Yeah, reasonable, I will discuss it with Andrey after he tries .devcontainer.

-- 
Regards
Junwang Zhao

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Official devcontainer config
  In-Reply-To: <CAEG8a3+av_p4fLA=dAAp1U7nMckt+D=qjEOVxqOio39u48qEkQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox