public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dean Rasheed <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: commented out code
Date: Tue, 20 Jan 2026 11:31:22 +0000
Message-ID: <CAEZATCX3SP0bjbkSurf6mkSJ8nGDPcv2+PfYvxNV9zdE4DCkeQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On Tue, 20 Jan 2026 at 08:49, Peter Eisentraut <[email protected]> wrote:
>
> On 05.12.25 17:38, Heikki Linnakangas wrote:
> > #if 0
> >      Oid      subtype = PG_GETARG_OID(3);
> > #endif
> >
> > is yet another option. It keeps the indentation, although you won't get
> > the compiler checking.
>
> After some reflection, I like this approach.  It keeps the indentation
> and enables syntax highlighting, so it makes some of these blocks much
> easier to read.

Quite a few other places use this pattern:

#ifdef NOT_USED
    Oid      subtype = PG_GETARG_OID(3);
#endif

Nothing #define's NOT_USED, so it works the same, but helps document
that the argument isn't used.

Regards,
Dean

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: commented out code
  In-Reply-To: <CAEZATCX3SP0bjbkSurf6mkSJ8nGDPcv2+PfYvxNV9zdE4DCkeQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox