public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ranier Vilela <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
Date: Mon, 13 May 2024 15:05:32 -0300
Message-ID: <CAEudQAoQ6pVAu4JS-KPgkPW_Nvb0bUbjGtYEwa7ADGOxQ=KVug@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAEudQAqMeE0AHcOsOzZx51Z0eiFJAjhBPRFt+Bxi3ETXWen7ig@mail.gmail.com>
<[email protected]>
<CAEudQArcwFzYdGcRk8Tyf2ij0DR7mOoqSJejsa00+SkTjFNHSw@mail.gmail.com>
<[email protected]>
Em qua., 10 de abr. de 2024 às 15:33, Daniel Gustafsson <[email protected]>
escreveu:
> On 10 Apr 2024, at 20:31, Ranier Vilela <[email protected]> wrote:
>
> Em ter., 2 de abr. de 2024 às 15:31, Daniel Gustafsson <[email protected]>
> escreveu:
>
>> > On 2 Apr 2024, at 20:13, Ranier Vilela <[email protected]> wrote:
>>
>> > Fix by freeing the pointer, like pclose_check (src/common/exec.c)
>> similar case.
>>
>> Off the cuff, seems reasonable when loglevel is LOG.
>>
>
> Per Coverity.
>
> Another case of resource leak, when loglevel is LOG.
> In the function shell_archive_file (src/backend/archive/shell_archive.c)
> The pointer *xlogarchcmd* is not freed.
>
>
> Thanks, I'll have a look. I've left this for post-freeze on purpose to not
> cause unnecessary rebasing. Will take a look over the next few days unless
> beaten to it.
>
Any chance we'll have these fixes in v17?
best regards,
Ranier Vilela
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
In-Reply-To: <CAEudQAoQ6pVAu4JS-KPgkPW_Nvb0bUbjGtYEwa7ADGOxQ=KVug@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox