public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Ranier Vilela <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
Date: Wed, 10 Apr 2024 20:33:03 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEudQArcwFzYdGcRk8Tyf2ij0DR7mOoqSJejsa00+SkTjFNHSw@mail.gmail.com>
References: <CAEudQAqMeE0AHcOsOzZx51Z0eiFJAjhBPRFt+Bxi3ETXWen7ig@mail.gmail.com>
	<[email protected]>
	<CAEudQArcwFzYdGcRk8Tyf2ij0DR7mOoqSJejsa00+SkTjFNHSw@mail.gmail.com>

> On 10 Apr 2024, at 20:31, Ranier Vilela <[email protected]> wrote:
> 
> Em ter., 2 de abr. de 2024 às 15:31, Daniel Gustafsson <[email protected] <mailto:[email protected]>> escreveu:
>> > On 2 Apr 2024, at 20:13, Ranier Vilela <[email protected] <mailto:[email protected]>> wrote:
>> 
>> > Fix by freeing the pointer, like pclose_check (src/common/exec.c) similar case.
>> 
>> Off the cuff, seems reasonable when loglevel is LOG.
> 
> Per Coverity.
> 
> Another case of resource leak, when loglevel is LOG.
> In the function shell_archive_file (src/backend/archive/shell_archive.c)
> The pointer *xlogarchcmd*  is not freed.

Thanks, I'll have a look.  I've left this for post-freeze on purpose to not
cause unnecessary rebasing.  Will take a look over the next few days unless
beaten to it.

--
Daniel Gustafsson

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox