public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ashutosh Bapat <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: SATYANARAYANA NARLAPURAM <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [Patch]Add Graph* node support to expression_tree_mutator
Date: Mon, 11 May 2026 11:45:59 +0530
Message-ID: <CAExHW5v1frgDptL_BsPq3-zt2q9zAkBkp80u3AyJtiQyJFTHRg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAHg+QDc97WFTSkXg=g_ZAH8GnY2gJrvq72cs+YjqEAuZgXnkAQ@mail.gmail.com>
	<CAExHW5swSoFHbL3F8nGKTx-qtk8W9inp0Afxfr+JBsQ6z2tmQw@mail.gmail.com>
	<CAExHW5vm8MA_w975hP==OkGhbX2uciinUjRp_Pk310fN5uGW8w@mail.gmail.com>
	<CA+TgmoZvC1XQe_QnTQnXyvrqP0WLn07NnNEmEPLzNQOjbnGXtw@mail.gmail.com>
	<CAExHW5t5_xs7sc0H2dT+QUsfEiNfTLtFKpCEE0Wr9ovF23dqoQ@mail.gmail.com>
	<[email protected]>

On Mon, May 4, 2026 at 9:09 PM Peter Eisentraut <[email protected]> wrote:
>
> On 30.04.26 08:44, Ashutosh Bapat wrote:
> > On Thu, Apr 30, 2026 at 2:17 AM Robert Haas <[email protected]> wrote:
> >>
> >
> > Thanks for reviewing the patch.
> >
> >> Thanks for working on this. I ran into it independently today, and
> >> then discovered this thread. In expression_tree_mutator_impl,
> >> T_GraphLabelRef can be added to the "Primitive node types with no
> >> expression subnodes" section just as was done in
> >> expression_tree_walker_impl.
> >
> > Right. Fixed in the attached patch. Both GraphPropertyLabel and
> > GraphLabelRef need to be placed in that section since both are
> > primitive nodes.
>
> Committed.  (I reformatted the test query a little bit as you had
> suggested upstream.  Also, the ordering of the switch cases was slightly
> different between the walker and the mutator, which I fixed.)
>

Thanks. The changes look good to me.

-- 
Best Wishes,
Ashutosh Bapat

view thread (7+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [Patch]Add Graph* node support to expression_tree_mutator
  In-Reply-To: <CAExHW5v1frgDptL_BsPq3-zt2q9zAkBkp80u3AyJtiQyJFTHRg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox