public inbox for [email protected]
help / color / mirror / Atom feedFrom: Srinath Reddy Sadipiralla <[email protected]>
To: Antonin Houska <[email protected]>
Cc: [email protected]
Cc: Mihail Nikalayeu <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Robert Treat <[email protected]>
Subject: Re: Adding REPACK [concurrently]
Date: Thu, 26 Mar 2026 18:49:53 +0530
Message-ID: <CAFC+b6qD+eP=AhA9GeoZS0UafTOcX12Son+S5ZKU-9H5ueGg+w@mail.gmail.com> (raw)
In-Reply-To: <46846.1774267234@localhost>
References: <[email protected]>
<9116.1772009759@localhost>
<CAFC+b6o2yzA80YmfEhmMO9puN8qvGRvr-15BBLn3UmJxPfpr2w@mail.gmail.com>
<100248.1772048475@localhost>
<4200.1772781295@localhost>
<29157.1774029970@localhost>
<46846.1774267234@localhost>
Hi Antonin,
On Mon, Mar 23, 2026 at 5:30 PM Antonin Houska <[email protected]> wrote:
>
> I could not resist digging in it deeper :-) Attached is a test that
> reproduces
> the crash - it includes the isolation tester enhancement that I posted
> separately [1]. It crashes reliably with v43 [2] if your fix v43-0005 is
> omitted.
>
+1, i tested the same and yeah it reproduces the crash ,also reviewed
the patch LGTM, except i think you need to add this to makefile, so that a
simple
make check would be enough to run the isolation test, i think this all
makes sense
if this [1] patch goes in.
diff --git a/contrib/test_decoding/Makefile b/contrib/test_decoding/Makefile
index acbcaed2feb..201e3c84cb4 100644
--- a/contrib/test_decoding/Makefile
+++ b/contrib/test_decoding/Makefile
@@ -9,7 +9,10 @@ REGRESS = ddl xact rewrite toast permissions
decoding_in_xact \
ISOLATION = mxact delayed_startup ondisk_startup concurrent_ddl_dml \
oldest_xmin snapshot_transfer subxact_without_top concurrent_stream
\
twophase_snapshot slot_creation_error catalog_change_snapshot \
- skip_snapshot_restore invalidation_distribution
parallel_session_origin
+ skip_snapshot_restore invalidation_distribution
parallel_session_origin \
+ filtering
+
+EXTRA_INSTALL = src/test/modules/injection_points
REGRESS_OPTS = --temp-config
$(top_srcdir)/contrib/test_decoding/logical.conf
ISOLATION_OPTS = --temp-config
$(top_srcdir)/contrib/test_decoding/logical.conf
[1] - https://www.postgresql.org/message-id/flat/4703.1774250534%40localhost
--
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/
view thread (8+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <CAFC+b6qD+eP=AhA9GeoZS0UafTOcX12Son+S5ZKU-9H5ueGg+w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox