public inbox for [email protected]
help / color / mirror / Atom feedFrom: Fabrízio de Royes Mello <[email protected]>
To: Thom Brown <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Space missing from EXPLAIN output
Date: Fri, 28 Feb 2025 13:54:13 -0300
Message-ID: <CAFcNs+qvagUy23M=DYwPa9jXFPFGz3L4-RfQysd_z_Ug=CQwXw@mail.gmail.com> (raw)
In-Reply-To: <CAA-aLv6nq=UeiyvM7_Mxgo9TVBzs2oh46b9vfyLzuyVEz3j1-g@mail.gmail.com>
References: <CAA-aLv6nq=UeiyvM7_Mxgo9TVBzs2oh46b9vfyLzuyVEz3j1-g@mail.gmail.com>
On Fri, Feb 28, 2025 at 1:38 PM Thom Brown <[email protected]> wrote:
> Hi,
>
> Commit ddb17e387aa introduced fractional row counts, but the rejigging
> has introduced a formatting issue:
>
> Worker 0: actual time=34.779..34.780rows=0 loops=1
> Buffers: shared hit=1200
> Worker 1: actual time=39.737..39.738rows=0 loops=1
> Buffers: shared hit=1084
>
> A space is missing between the time values and the "rows" label.
>
>
Are you sure your main is updated? The current main
is 424ededc580b03e1bcf8aff18a735e519c80061f.
Because your patch is not applying:
main on main [$]
➜ git apply /tmp/fix_explain_analyze_spacing.diff
error: patch failed: src/backend/commands/explain.c:2075
error: src/backend/commands/explain.c: patch does not apply
On the current main your change should be on line 2041 and not 2075
according to your patch.
Regards,
--
Fabrízio de Royes Mello
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Space missing from EXPLAIN output
In-Reply-To: <CAFcNs+qvagUy23M=DYwPa9jXFPFGz3L4-RfQysd_z_Ug=CQwXw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox