public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dilip Kumar <[email protected]>
To: [email protected] <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: [email protected] <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Perform streaming logical transactions by background workers and parallel apply
Date: Sat, 7 Jan 2023 14:25:31 +0530
Message-ID: <CAFiTN-sgQ-K9BnMWKLR7Hm36QNjS7ZOBF6hsXJmQz5ChC0Desw@mail.gmail.com> (raw)
In-Reply-To: <OS3PR01MB5718AE486227CE3ACB844C5E94F89@OS3PR01MB5718.jpnprd01.prod.outlook.com>
References: <CAA4eK1LGmZsevrqJra0V4O8oBU_eKyzm2VMpSAYQaDgC6n4fkA@mail.gmail.com>
<CAFiTN-uhnJkrUsQByBHMK268T-GEx_D8DQ6b2T+aW6RiU75pbQ@mail.gmail.com>
<OS0PR01MB571621ED532C2D7C3E01625894FB9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAFiTN-t5+_zTf86EzgCwObs1ED-P_5Ab1KMw340d3oPY_+Cwpw@mail.gmail.com>
<OS3PR01MB5718AE486227CE3ACB844C5E94F89@OS3PR01MB5718.jpnprd01.prod.outlook.com>
On Sat, Jan 7, 2023 at 11:13 AM [email protected]
<[email protected]> wrote:
>
> On Saturday, January 7, 2023 12:50 PM Dilip Kumar <[email protected]>
> >
> > On Fri, Jan 6, 2023 at 3:38 PM [email protected] <[email protected]>
> > wrote:
> > >
> >
> > Looks good, but I feel in pa_process_spooled_messages_if_required()
> > function after getting the filestate the first check should be if (filestate==
> > FS_EMPTY) return false. I mean why to process through all the states if it is
> > empty and we can directly exit. It is not a big deal so if you prefer the way it is
> > then I have no objection to it.
>
> I think your suggestion looks good, I have adjusted the code.
> I also rebase the patch set due to the recent commit c6e1f6.
> And here is the new version patch set.
>
LGTM
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Perform streaming logical transactions by background workers and parallel apply
In-Reply-To: <CAFiTN-sgQ-K9BnMWKLR7Hm36QNjS7ZOBF6hsXJmQz5ChC0Desw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox