public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jelte Fennema <[email protected]>
To: Jacob Champion <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Michael Paquier <[email protected]>
Subject: Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()
Date: Thu, 16 Feb 2023 12:31:46 +0100
Message-ID: <CAGECzQR6p6HuMxPVNmovW0n5pAyBjDDz661hR1D9FwsKRuMH=A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Patch looks good to me. Definitely an improvement over the status quo.

Looking at the TLS error handling though I see these two lines:

&& conn->allow_ssl_try    /* redundant? */
&& !conn->wait_ssl_try) /* redundant? */

Are they actually redundant like the comment suggests? If so, we
should probably remove them (in another patch). If not (or if we don't
know), should we have these same checks for GSS?

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()
  In-Reply-To: <CAGECzQR6p6HuMxPVNmovW0n5pAyBjDDz661hR1D9FwsKRuMH=A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox