public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jelte Fennema-Nio <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Jacob Champion <[email protected]>
Subject: Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore
Date: Wed, 8 Jul 2026 00:28:42 +0200
Message-ID: <CAGECzQSF214DY91QRNRCSqJhJKy4r83qTcmdX-FdFbh6h26K1g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Tue, 7 Jul 2026 at 16:52, Heikki Linnakangas <[email protected]> wrote:
> Yeah, I guess that works.. But It's a little unsatisfactory to have to
> poll, where we didn't poll before. I started to go down the rabbit hole,
> here are the options I can think of:

Honestly, I like the fallback to 1-second polling quite a bit better
than any of the options you proposed. The benefit of your options
(afaict) is making sure a very rare 1 second delay in a cancel for
pg_dump/pg_restore cannot happen on most platforms. That seems like a
rather insignificant benefit. But to achieve that the code on Windows
(and depending on the option other platforms) is now different, which
makes testing any future changes to the code much harder for anyone
who doesn't have Windows. I don't think the benefit is worth that
downside in this instance.

I guess my general thoughts on this is that I would like the behaviour
of Windows and Unix to become closer, not further apart (unless there
are significant benefits to doing so).

view thread (24+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore
  In-Reply-To: <CAGECzQSF214DY91QRNRCSqJhJKy4r83qTcmdX-FdFbh6h26K1g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox