public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kuntal Ghosh <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Avoid multiple SetLatch() calls in procsignal_sigusr1_handler()
Date: Wed, 1 Mar 2023 15:14:36 +0530
Message-ID: <CAGz5QCLd8wm_KxZW=W+=roHnv+yS8pvw2qLP=G=FxDH53aee_g@mail.gmail.com> (raw)
In-Reply-To: <CALj2ACWd5apddj6Cd885WwJ6LquYu_G81C4GoR4xSoDV1x-FEA@mail.gmail.com>
References: <CALj2ACWd5apddj6Cd885WwJ6LquYu_G81C4GoR4xSoDV1x-FEA@mail.gmail.com>

On Tue, Feb 28, 2023 at 9:01 PM Bharath Rupireddy
<[email protected]> wrote:
>
> Most of the multiplexed SIGUSR1 handlers are setting latch explicitly
> when the procsignal_sigusr1_handler() can do that for them at the end.
> These multiplexed handlers are currently being used as SIGUSR1
> handlers, not as independent handlers, so no problem if SetLatch() is
> removed from them. A few others do it right by saying /* latch will be
> set by procsignal_sigusr1_handler */. Although, calling SetLatch() in
> quick succession does no harm (it just returns if the latch was
> previously set), it seems unnecessary.
>
+1



-- 
Thanks & Regards,
Kuntal Ghosh

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Avoid multiple SetLatch() calls in procsignal_sigusr1_handler()
  In-Reply-To: <CAGz5QCLd8wm_KxZW=W+=roHnv+yS8pvw2qLP=G=FxDH53aee_g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox