public inbox for [email protected]  

help / color / mirror / Atom feed

From: solaimurugan vellaipandiyan <[email protected]>
To: Payal Singh <[email protected]>
Cc: [email protected]
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
Date: Sun, 10 May 2026 19:29:53 +0530
Message-ID: <CAHEL7KRa-rmSCvREEYrdsY97PNgJtqLYfOikfZWEK4enNQhM0Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi Aleksander,

I tested v7 of the patch on current HEAD.

The patch applied cleanly and multiline comments were reformatted
correctly in my testing. I also verified that repeated pgindent runs
did not produce additional changes, and git diff --check was clean.

While testing some real PostgreSQL source files, I noticed
banner-style comments in contrib/seg/seg.c still receive formatting
changes like:

-  This file contains routines ...

+ *  This file contains routines ...


This looks similar to the earlier discussion around separator-style
comments and possible unnecessary diff churn. Since these header
comments already appear visually structured, perhaps preserving them
could help reduce additional formatting noise.

Apart from that observation, the patch looked good overall in my testing.

Regards,
solai murugan

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
  In-Reply-To: <CAHEL7KRa-rmSCvREEYrdsY97PNgJtqLYfOikfZWEK4enNQhM0Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox