public inbox for [email protected]
help / color / mirror / Atom feedFrom: Fujii Masao <[email protected]>
To: wang.xiao.peng <[email protected]>
Cc: Chao Li <[email protected]>
Cc: [email protected]
Cc: PostgreSQL Hackers <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Hannu Krosing <[email protected]>
Subject: Re: Re: pg_test_timing: fix unit typo and widen diff type
Date: Wed, 22 Apr 2026 16:04:16 +0900
Message-ID: <CAHGQGwEM=s5vXPpXoismwRMNCnAmwwMJPnQEQYbPFTJGouV0rQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CAP53PkwEZ+UMmwA8cbUSUdE6phXi+xWmn5t-YAnvKf0qoBnOvg@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
On Thu, Apr 9, 2026 at 3:13 PM wang.xiao.peng <[email protected]> wrote:
> Just finished reviewing the v3 patches - looks good to me. The pg_leftmost_one_pos64 fix is spot on, and using INT64_FORMAT for the error message is the right approach.
Since pg_leftmost_one_pos64() can return up to 63, should the size of
histogram[] be changed from 32 to 64? If we want to display the full
histogram[] in the output, max_bit in output() would also need to be set to 63.
Alternatively, it may be fine to keep max_bit = 31 and show only
the first 32 histogram entries.
Patch 0001 looks good to me.
Regards,
--
Fujii Masao
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Re: pg_test_timing: fix unit typo and widen diff type
In-Reply-To: <CAHGQGwEM=s5vXPpXoismwRMNCnAmwwMJPnQEQYbPFTJGouV0rQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox