public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Sami Imseih <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: shihao zhong <[email protected]>
Subject: Re: Add missing stats_reset column to pg_statio_all_sequences view
Date: Fri, 13 Mar 2026 10:39:36 +0900
Message-ID: <CAHGQGwGA5d0uigSj78xCyjPdc+j3V-qvxk=_NfbV6ScOrGQvbQ@mail.gmail.com> (raw)
In-Reply-To: <CAA5RZ0vwTY=cVUWSiCFQbz9m5-DQoM=ELLz+ggn+SR-R9H7xpQ@mail.gmail.com>
References: <CAA5RZ0v0OPGyDpwxkX81CtTt9xsj9-TNxhm=8JdOvEKPsVVFNg@mail.gmail.com>
	<CAA5RZ0vwTY=cVUWSiCFQbz9m5-DQoM=ELLz+ggn+SR-R9H7xpQ@mail.gmail.com>

On Fri, Mar 13, 2026 at 7:44 AM Sami Imseih <[email protected]> wrote:
>
> After Creating this thread and the CF entry for it [1], I realized Shihao also
> created [2] yesterday. Sorry about that.
>
> We can stick with 6582 and Shihao can also get author credit.

Thanks to both Shihao and Sami for proposing patches!

Since the two patches are almost the same, I reviewed Sami's patch.
It looks good to me overall. One comment: for the tests added to stats.sql,
it would be better to verify that the stats of the specified sequence are
actually reset by using pg_stat_reset_single_table_counters().

Also, the documentation for pg_stat_reset_single_table_counters() should
mention that it can reset sequence statistics as well.

Regards,

-- 
Fujii Masao

view thread (24+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Add missing stats_reset column to pg_statio_all_sequences view
  In-Reply-To: <CAHGQGwGA5d0uigSj78xCyjPdc+j3V-qvxk=_NfbV6ScOrGQvbQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox