public inbox for [email protected]
help / color / mirror / Atom feedRe: Remove MSVC scripts from the tree
4+ messages / 4 participants
[nested] [flat]
* Re: Remove MSVC scripts from the tree
@ 2023-09-22 06:06 Peter Eisentraut <[email protected]>
2023-09-25 04:00 ` Re: Remove MSVC scripts from the tree Michael Paquier <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Peter Eisentraut @ 2023-09-22 06:06 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; Postgres hackers <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; [email protected]
On 22.09.23 03:12, Michael Paquier wrote:
> It has been mentioned a few times now that, as Meson has been
> integrated in the tree, the next step would be to get rid of the
> custom scripts in src/tools/msvc/ and moving forward only support
> Meson when building with VS compilers.
First we need to fix things so that we can build using meson from a
distribution tarball, which is the subject of
<https://commitfest.postgresql.org/44/4357/;.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Remove MSVC scripts from the tree
2023-09-22 06:06 Re: Remove MSVC scripts from the tree Peter Eisentraut <[email protected]>
@ 2023-09-25 04:00 ` Michael Paquier <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Michael Paquier @ 2023-09-25 04:00 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: Postgres hackers <[email protected]>; Andrew Dunstan <[email protected]>; [email protected]
On Fri, Sep 22, 2023 at 08:06:57AM +0200, Peter Eisentraut wrote:
> First we need to fix things so that we can build using meson from a
> distribution tarball, which is the subject of
> <https://commitfest.postgresql.org/44/4357/;.
Thanks, missed this one.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 4+ messages in thread
* Wrong argument name in error message from attribute_stats functions
@ 2026-07-10 12:11 Ilia Evdokimov <[email protected]>
2026-07-10 12:32 ` Re: Wrong argument name in error message from attribute_stats functions Fujii Masao <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Ilia Evdokimov @ 2026-07-10 12:11 UTC (permalink / raw)
To: PostgreSQL Hackers <[email protected]>
Hi,
While using pg_clear_attribute_stats() I noticed weird printing:
```
CREATE TABLE t(a int);
SELECT pg_clear_attribute_stats(NULL, 't', 'a', false);
ERROR: argument "relation" must not be null
```
NULL was passed for `schemaname`, not for a `relation` argument. This
comes from cleararginfo[], where both the schema and relname entries are
labeled `relation`.
In v1-patch I propose naming these the same way `pg_proc.dat` does, i.e.
`schemaname` and `relname`.
After applying patch:
```
SELECT pg_clear_attribute_stats(NULL, 't', 'a', false);
ERROR: argument "schemaname" must not be null
SELECT pg_clear_attribute_stats('public', NULL, 'a', false);
ERROR: argument "relname" must not be null
```
--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC,
https://tantorlabs.com/
Attachments:
[text/x-patch] v1-0001-Wrong-argument-name-in-error-message-from-attribu.patch (1014B, ../../[email protected]/2-v1-0001-Wrong-argument-name-in-error-message-from-attribu.patch)
download | inline diff:
From 396adba853e9ea2956e581e7cf71c39da8a2cdaf Mon Sep 17 00:00:00 2001
From: Ilia Evdokimov <[email protected]>
Date: Fri, 10 Jul 2026 14:58:34 +0300
Subject: [PATCH v1] Wrong argument name in error message from attribute_stats
functions
---
src/backend/statistics/attribute_stats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/statistics/attribute_stats.c b/src/backend/statistics/attribute_stats.c
index 2efb74b95a6..fac6168f916 100644
--- a/src/backend/statistics/attribute_stats.c
+++ b/src/backend/statistics/attribute_stats.c
@@ -97,8 +97,8 @@ enum clear_attribute_stats_argnum
static struct StatsArgInfo cleararginfo[] =
{
- [C_ATTRELSCHEMA_ARG] = {"relation", TEXTOID},
- [C_ATTRELNAME_ARG] = {"relation", TEXTOID},
+ [C_ATTRELSCHEMA_ARG] = {"schemaname", TEXTOID},
+ [C_ATTRELNAME_ARG] = {"relname", TEXTOID},
[C_ATTNAME_ARG] = {"attname", TEXTOID},
[C_INHERITED_ARG] = {"inherited", BOOLOID},
[C_NUM_ATTRIBUTE_STATS_ARGS] = {0}
--
2.34.1
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Wrong argument name in error message from attribute_stats functions
2026-07-10 12:11 Wrong argument name in error message from attribute_stats functions Ilia Evdokimov <[email protected]>
@ 2026-07-10 12:32 ` Fujii Masao <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Fujii Masao @ 2026-07-10 12:32 UTC (permalink / raw)
To: Ilia Evdokimov <[email protected]>; +Cc: PostgreSQL Hackers <[email protected]>
On Fri, Jul 10, 2026 at 9:11 PM Ilia Evdokimov
<[email protected]> wrote:
>
> Hi,
>
> While using pg_clear_attribute_stats() I noticed weird printing:
>
> ```
> CREATE TABLE t(a int);
> SELECT pg_clear_attribute_stats(NULL, 't', 'a', false);
> ERROR: argument "relation" must not be null
> ```
>
> NULL was passed for `schemaname`, not for a `relation` argument. This
> comes from cleararginfo[], where both the schema and relname entries are
> labeled `relation`.
>
> In v1-patch I propose naming these the same way `pg_proc.dat` does, i.e.
> `schemaname` and `relname`.
Thanks for the patch! LGTM.
Regards,
--
Fujii Masao
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-07-10 12:32 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-09-22 06:06 Re: Remove MSVC scripts from the tree Peter Eisentraut <[email protected]>
2023-09-25 04:00 ` Michael Paquier <[email protected]>
2026-07-10 12:11 Wrong argument name in error message from attribute_stats functions Ilia Evdokimov <[email protected]>
2026-07-10 12:32 ` Re: Wrong argument name in error message from attribute_stats functions Fujii Masao <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox