public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Chao Li <[email protected]>
Cc: Robert Treat <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: DOC: fixes multiple errors in alter table doc
Date: Mon, 9 Mar 2026 18:43:39 +0900
Message-ID: <CAHGQGwGfqYkkot9C-9ALov7OrjYPTw=YbGufV2mBZnrJ1k4QeQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAEoWx2n6ShLMOnjOtf63TjjgGbgiTVT5OMsSOFmbjGb6Xue1Bw@mail.gmail.com>
	<CABV9wwMPmo-dg=oV+NaJGa_==uo5+TTvk58aNtjVQZBtMcRVBw@mail.gmail.com>
	<CAEoWx2kkh5kCZwYOYaOVShjh3un2mJTGrcFZyhJXd320PHYfJw@mail.gmail.com>
	<CAJSLCQ10_gia2-GzQndwoM-n-v2DWz4LnAY5jyO2ZmNiE+56tA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAEoWx2mOW=JMjSNrNsc3b-+8w0wbT2f6FSsyudD_Q-0pe_fkfw@mail.gmail.com>
	<CAHGQGwFk=rrhrwGwPtQxBesbT4DzSZ86Q3ftcwCu3AR5bOiXLw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAJSLCQ3h6fyMNaH1PnUPXRTdkkH+3+ctEogG4YUWY+XtQUKH6g@mail.gmail.com>
	<[email protected]>
	<CAHGQGwFdKQddg6GzLHirjVTf=ewFdXyL7kwzZwghbvO19EtrwQ@mail.gmail.com>
	<[email protected]>
	<CAHGQGwEQZp3TotP9Aga0tpGj5fcAKSwH8uwHkR2Cc=BM8Q9VMg@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On Fri, Mar 6, 2026 at 4:53 PM Chao Li <[email protected]> wrote:
> PFA v6.

Thanks for updating the patch!

> The two test cases on table level “IF EXISTS” are removed. So, now the patch adds totally 4 test cases: 2 for omitting COLUMN, 2 for combinations of column level “IF [NOT] EXISTS” and omitting COUMN.

The latest patch doesn't seem to include the combination of column-level
IF NOT EXISTS for ADD COLUMN and omitting COLUMN.


Based on your patch, I updated the regression tests as follows and
pushed the changes:

+ALTER FOREIGN TABLE ft1 ADD c11 integer; -- omit COLUMN
+ALTER FOREIGN TABLE ft1 DROP c11; -- omit COLUMN

I moved the ALTER FOREIGN TABLE DROP test into the section that lists the other
existing ALTER FOREIGN TABLE DROP COLUMN tests.

Regarding table-level IF EXISTS tests, it seemed to me that most
ALTER FOREIGN TABLE ADD/DROP variants should also be tested there,
following the existing structure in foreign_data.sql. So I added some
additional cases, for example ALTER FOREIGN TABLE IF EXISTS ADD COLUMN IF
NOT EXISTS.

Regards,

-- 
Fujii Masao

view thread (11+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: DOC: fixes multiple errors in alter table doc
  In-Reply-To: <CAHGQGwGfqYkkot9C-9ALov7OrjYPTw=YbGufV2mBZnrJ1k4QeQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox