public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Treat <[email protected]>
To: Chao Li <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: DOC: fixes multiple errors in alter table doc
Date: Mon, 2 Mar 2026 23:41:13 -0500
Message-ID: <CAJSLCQ3h6fyMNaH1PnUPXRTdkkH+3+ctEogG4YUWY+XtQUKH6g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAEoWx2n6ShLMOnjOtf63TjjgGbgiTVT5OMsSOFmbjGb6Xue1Bw@mail.gmail.com>
	<CABV9wwMPmo-dg=oV+NaJGa_==uo5+TTvk58aNtjVQZBtMcRVBw@mail.gmail.com>
	<CAEoWx2kkh5kCZwYOYaOVShjh3un2mJTGrcFZyhJXd320PHYfJw@mail.gmail.com>
	<CAJSLCQ10_gia2-GzQndwoM-n-v2DWz4LnAY5jyO2ZmNiE+56tA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAEoWx2mOW=JMjSNrNsc3b-+8w0wbT2f6FSsyudD_Q-0pe_fkfw@mail.gmail.com>
	<CAHGQGwFk=rrhrwGwPtQxBesbT4DzSZ86Q3ftcwCu3AR5bOiXLw@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On Mon, Mar 2, 2026 at 9:09 PM Chao Li <[email protected]> wrote:
> > On Mar 2, 2026, at 17:22, Chao Li <[email protected]> wrote:
> >> On Mar 2, 2026, at 17:04, Fujii Masao <[email protected]> wrote:
> >> On Thu, Jan 22, 2026 at 6:38 PM Chao Li <[email protected]> wrote:
> >>> PFA v3: Rebased, and added reviewer and discussion information.
> >>
> >> LGTM.
> >>
> >> Should we apply the same change to the ALTER FOREIGN TABLE docs as well?
> >
> > Sure, I can make the change.
> >
> >>
> >> While reviewing that section, I noticed that ADD COLUMN IF NOT EXISTS appears
> >> to work for ALTER FOREIGN TABLE, but it isn't documented. I'm not sure why
> >> it was left out, but perhaps we should document it and add a regression test in
> >> a separate patch?
> >>
> >
> > I will verify that, then update the doc and regression test accordingly.
> >
> > Best regards,
> > --
> > Chao Li (Evan)
> > HighGo Software Co., Ltd.
> > https://www.highgo.com/
> >
>
> PFA v4:
>
> 0001 - alter table related changes
>
>  * Add test cases for omitting COLUMN of ALTER TABLE ADD/DROP [COLUMN]
>  * Add a test case for ADD COLUMN IF NOT EXIST (already had DROP COLUMN IF EXIST)
>
> 0002 - alter foreign table related changes
>
>  * doc: Add IF NOT EXSTS for ADD COLUMN
>  * doc: Mark COLUMN as optional for ADD/DROP COLUMN in the same way as 0001
>  * Add test cases for omitting COLUMN of ALTER FOREIGN TABLE ADD/DROP [COLUMN]
>  * Add a test cases for for ADD COLUMN IF NOT EXIST
>  * Add a test cases for for DROP COLUMN IF EXIST
>

LGTM, although I was curious why you went with c12 vs c11 in
+ALTER FOREIGN TABLE ft1 ADD c12 integer; -- omit COLUMN
or maybe that should be changed?


Robert Treat
https://xzilla.net

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: DOC: fixes multiple errors in alter table doc
  In-Reply-To: <CAJSLCQ3h6fyMNaH1PnUPXRTdkkH+3+ctEogG4YUWY+XtQUKH6g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox