public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Zhenwei Shang <[email protected]>
Cc: Afrah Razzak <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] psql: Add missing IO option to EXPLAIN tab completion
Date: Sat, 23 May 2026 09:41:21 +0900
Message-ID: <CAHGQGwHPA_Zc0=-p8Fc=n1HXwf0UABp=XWCyq9r3vPca7ajDGQ@mail.gmail.com> (raw)
In-Reply-To: <CABv9HUmAh6UHwePG0PkP-suSweCJDiBcwwLjrSUbZWhVi8xZQg@mail.gmail.com>
References: <CAAJ6gzGi9gK6nGjsGCch0nFPdd2+odWatTS1uAGwRDPbHkmSVQ@mail.gmail.com>
	<CABv9HUmAh6UHwePG0PkP-suSweCJDiBcwwLjrSUbZWhVi8xZQg@mail.gmail.com>

On Wed, May 13, 2026 at 2:49 PM Zhenwei Shang <[email protected]> wrote:
>
>
>
> Afrah Razzak <[email protected]> 于2026年5月13日周三 11:35写道：
>>
>> Hi,
>>
>> Commit 681daed9316 added EXPLAIN (IO) as a new boolean option, but
>> psql's tab completion was not updated to include it.
>>
>> Currently:
>>
>>     EXPLAIN (<Tab>      -- IO is not listed
>>   EXPLAIN (IO <Tab>   -- no ON/OFF offered
>>
>> The attached patch adds IO to both the option keyword list and the
>> boolean ON/OFF completion pattern in tab-complete.in.c.
>>
>> Thanks,
>> Afrah Razzak
>>
> Looks correct to me. EXPLAIN (IO) is a boolean option, so adding it to both the option keyword list and the ON/OFF completion branch is the right fix.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] psql: Add missing IO option to EXPLAIN tab completion
  In-Reply-To: <CAHGQGwHPA_Zc0=-p8Fc=n1HXwf0UABp=XWCyq9r3vPca7ajDGQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox