public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Baji Shaik <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Fix psql tab completion for REPACK boolean options
Date: Mon, 18 May 2026 13:17:13 +0900
Message-ID: <CAHGQGwHhBvDj=cyko-zdeEVtpCTvXNOESsLZCYsCB0C50T-unQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAHGQGwGAY4kfDtC4i+hAOX-a3u0yOA6__6EDTQz-ytsDHgh-yQ@mail.gmail.com>
	<[email protected]>

On Fri, May 15, 2026 at 11:32 PM Álvaro Herrera <[email protected]> wrote:
> > Second, when the same option is specified multiple times, the last value
> > is not always honored. In particular, if any occurrence sets an option to ON,
> > the option remains enabled even when the final setting is OFF.
> >
> > I think these are bugs, and the attached patch fixes them. Thoughts?
>
> I agree that these are bugs.  The patch looks good to me on a cursory
> look, though I didn't actually test it.

Thanks for the review! I've tested it again and then pushed it.

Regards,

-- 
Fujii Masao

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix psql tab completion for REPACK boolean options
  In-Reply-To: <CAHGQGwHhBvDj=cyko-zdeEVtpCTvXNOESsLZCYsCB0C50T-unQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox