public inbox for [email protected]  
help / color / mirror / Atom feed
From: SATYANARAYANA NARLAPURAM <[email protected]>
To: Richard Guo <[email protected]>
Cc: Chao Li <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Subject: Re: Bug: Rule actions see wrong values for generated columns (NEW.gen reads OLD value)
Date: Mon, 13 Apr 2026 01:42:49 -0700
Message-ID: <CAHg+QDda7fkd_z6ZXuhRVtVyRf2J=BCP9nRrHqL2_0=HWQnzSA@mail.gmail.com> (raw)
In-Reply-To: <CAMbWs4-_nPuNSKeaEnU81MQK8fKq5Lr5W0dYhzcL4DW61KLNHQ@mail.gmail.com>
References: <CAHg+QDexGTmCZzx=73gXkY2ZADS6LRhpnU+-8Y_QmrdTS6yUhA@mail.gmail.com>
	<CAMbWs4-SJ6B26ciFu_K_2M1ObDA=GirV87N1BKeAtSRmQGATUA@mail.gmail.com>
	<[email protected]>
	<CAHg+QDf1Y=dZR8i+q3nnjEt2qeJpDG_pvrWtozXTrdu3J8H-FQ@mail.gmail.com>
	<CAMbWs4-_nPuNSKeaEnU81MQK8fKq5Lr5W0dYhzcL4DW61KLNHQ@mail.gmail.com>

Hi Richard,

On Mon, Apr 13, 2026 at 1:30 AM Richard Guo <[email protected]> wrote:

> On Mon, Apr 13, 2026 at 4:27 PM SATYANARAYANA NARLAPURAM
> <[email protected]> wrote:
> > On Mon, Apr 13, 2026 at 12:21 AM Chao Li <[email protected]> wrote:
> >> Do either of you plan to propose a patch for this? If so, please go
> ahead and I can review it. Otherwise, I can propose a patch in a couple of
> days.
>
> > I have a patch with me, let me post it shortly.
>
> Please feel free to share your patches.  I've been looking into this
> as well, but I'd be happy to see independent takes on it.
>

I reviewed your patch, it looks good. I ran the tests you added and a few
additional tests and they are passing. Please continue with your patch.
Maybe a test like "WHERE NEW.b > threshold" to confirm the expansion
happens before qual evaluation would be good.

Thanks,
Satya


view thread (16+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Bug: Rule actions see wrong values for generated columns (NEW.gen reads OLD value)
  In-Reply-To: <CAHg+QDda7fkd_z6ZXuhRVtVyRf2J=BCP9nRrHqL2_0=HWQnzSA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox