public inbox for [email protected]  

help / color / mirror / Atom feed

From: SATYANARAYANA NARLAPURAM <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Antonin Houska <[email protected]>
Subject: Re: [Bug]Vacuum full silently NULL out fast default columns
Date: Mon, 4 May 2026 11:08:06 -0700
Message-ID: <CAHg+QDegHnVEFdmp8e_k6b4DhC4R0MpCv26SEhz6gYSeZt-nVw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAHg+QDeteXPbPFsThTGTL=qp4dgiP1AH1kKktifcksDbiaRROw@mail.gmail.com>
	<[email protected]>

Hi,

On Mon, May 4, 2026 at 10:41 AM Álvaro Herrera <[email protected]> wrote:

> On 2026-May-04, SATYANARAYANA NARLAPURAM wrote:
>
> > On Mon, May 4, 2026 at 6:40 AM Tom Lane <[email protected]> wrote:
>
> > > A quick bisect run agrees that it broke here:
> > >
> > > 28d534e2ae0ac888b5460f977a10cd9bb017ef98 is the first bad commit
> > > commit 28d534e2ae0ac888b5460f977a10cd9bb017ef98 (HEAD)
> > > Author: Álvaro Herrera <[email protected]>
> > > Date:   Mon Apr 6 21:55:08 2026 +0200
> > >
> > >     Add CONCURRENTLY option to REPACK
>
> Right.
>
> > Thanks for reviewing! Attached v2 patch. Agreed, tried to optimize LOC in
> > V1. Before the change loop was not breaking early, I fixed that as
> > well in V2.
>
> Yeah, this seems a good approach to me.  I propose some more comment
> updates though, and I also thought it'd be a good idea to add a test for
> REPACK CONCURRENTLY while at it.
>

This patch LGTM. It applied cleanly and all the tests passed.

Thanks,
Satya

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [Bug]Vacuum full silently NULL out fast default columns
  In-Reply-To: <CAHg+QDegHnVEFdmp8e_k6b4DhC4R0MpCv26SEhz6gYSeZt-nVw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox